Thank you for this!
Based on internal discussions, should we -DCMAKE_BUILD_TYPE=Debug so that we enable the checked STL functionality and get good stack traces when there are failures. Or are we going to stand up a different bot for that use case?
As another option, if you have a clean diff, you could use the WebUI to upload that. There is "Update Diff" link on the right top corner of this screen. Click that and follow the sequence of the pages. Maybe it would be easier?
Apparently ClangBuilder does not support vs="autodetect" along with the test suite.
The problem is in these lines:
test_suite_env = copy.deepcopy(env) test_suite_env['CC'] = cc test_suite_env['CXX'] = cxx
In case of "autodetect" env is a build property, not a dictionary, and it does not support explicit assignments to CC and CXX.
I'll see if I can get some time to look into this issue over weekend or earlier next week. Please feel free to propose a patch if somebody else has some spare time to fix this issue, .
In the mean time, @aaron.ballman, could you revert this patch, please?
This differential revision is referenced from the commit and is a part of the git history. So, you need to restore the diff to the original form which has been approved and committed.
There are multiple possible ways of doing so, the easiest, I think, is just download the raw diff from https://reviews.llvm.org/file/data/6esxbhtveros4tnrzliu/PHID-FILE-ygiily67vdz436p5gmmb/file, then click "Update Diff" here (top right part of the screen), and upload that saved diff.
Please let me know if you need a help with this.
Once the diff is updated to the correct one, leave this review as is without changing anything else.