add a target dump section-load-list command for inspecting the Target's SectionLoadList

[jasonmolenda]

Summary

When debugging possible issues with the Target's SectionLoadList table, it would be helpful to have a way to dump all of the entries. Add that.

[mib]

That's indeed very helpful! LGTM!

[mib]

lldb/source/Target/SectionLoadList.cpp

265–266 ↗

(On Diff #536049)

Out of curiosity, why did you remove the section part ?

[jasonmolenda]

lldb/source/Target/SectionLoadList.cpp

265–266 ↗

(On Diff #536049)

I was being grumpy when I saw all the fields SectionLoadList::Dump was outputting and removed one of them to make me feel better, but I have to acknowledge that seeing the actual Section* value for the section may be helpful when debugging lldb. I'll remove this part of the change.

lldb/source/Commands/CommandObjectTarget.cpp

for (lldb::TypeSystemSP ts : GetSelectedTarget().GetScratchTypeSystems())
       if (ts)
         ts->Dump(result.GetOutputStream().AsRawOstream());
 
     result.SetStatus(eReturnStatusSuccessFinishResult);
     return result.Succeeded();
   }
 };
 
+#pragma mark CommandObjectTargetDumpSectionLoadList
+
+/// Dumps the SectionLoadList of the selected Target.
+class CommandObjectTargetDumpSectionLoadList : public CommandObjectParsed {
+public:
+  CommandObjectTargetDumpSectionLoadList(CommandInterpreter &interpreter)
+      : CommandObjectParsed(
+            interpreter, "target dump section-load-list",
+            "Dump the state of the target's internal section load list. "
+            "Intended to be used for debugging LLDB itself.",
+            nullptr, eCommandRequiresTarget) {}
+
+  ~CommandObjectTargetDumpSectionLoadList() override = default;
+
+protected:
+  bool DoExecute(Args &command, CommandReturnObject &result) override {
+    Target &target = GetSelectedTarget();
+    target.GetSectionLoadList().Dump(result.GetOutputStream(), &target);
+    result.SetStatus(eReturnStatusSuccessFinishResult);
+    return result.Succeeded();
+  }
+};
+
 #pragma mark CommandObjectTargetDump
 
 /// Multi-word command for 'target dump'.
 class CommandObjectTargetDump : public CommandObjectMultiword {
 public:
   // Constructors and Destructors
   CommandObjectTargetDump(CommandInterpreter &interpreter)
       : CommandObjectMultiword(
             interpreter, "target dump",
             "Commands for dumping information about the target.",
-            "target dump [typesystem]") {
+            "target dump [typesystem|section-load-list]") {
     LoadSubCommand(
         "typesystem",
         CommandObjectSP(new CommandObjectTargetDumpTypesystem(interpreter)));
+    LoadSubCommand("section-load-list",
+                   CommandObjectSP(new CommandObjectTargetDumpSectionLoadList(
+                       interpreter)));
   }
 
   ~CommandObjectTargetDump() override = default;
 };
 
 #pragma mark CommandObjectMultiwordTarget
 
 // CommandObjectMultiwordTarget