This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Add fixed vector insert tests that are pass by value
ClosedPublic

Authored by luke on Jun 28 2023, 4:59 AM.

Details

Summary

So we can still test insert_vector_elt lowering with D152276

Diff Detail

Event Timeline

luke created this revision.Jun 28 2023, 4:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 28 2023, 4:59 AM
luke requested review of this revision.Jun 28 2023, 4:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 28 2023, 4:59 AM
frasercrmck accepted this revision.Jun 28 2023, 5:03 AM

LGTM with that one test fixed

llvm/test/CodeGen/RISCV/rvv/fixed-vectors-insert.ll
360

ret %b here.

This revision is now accepted and ready to land.Jun 28 2023, 5:03 AM
luke added inline comments.Jun 28 2023, 5:11 AM
llvm/test/CodeGen/RISCV/rvv/fixed-vectors-insert.ll
360

Whoops, good catch!

luke updated this revision to Diff 535339.Jun 28 2023, 5:15 AM

Fix typo

This revision was automatically updated to reflect the committed changes.