Initial support for doacross clause in ordered directive.
This is intend to replace depend clause in ordered directive.
Details
Diff Detail
Event Timeline
clang/lib/Parse/ParseOpenMP.cpp | ||
---|---|---|
4424–4448 | Can it be unified with depenbd clause parsing? (Maybe in a separate template function) | |
clang/lib/Sema/SemaOpenMP.cpp | ||
91 | DoacrossClauseMapTy? Since it is intended to handle also doacross clauses. | |
11296–11332 | Try to avoid copy-paste. Maybe introduce templated function? | |
11346–11359 | Same, try to avoid copy-paste | |
24033 | Same, if possible try to unify handling with the depend clause, if possible |
Thanks Alexey for the review.
clang/lib/Parse/ParseOpenMP.cpp | ||
---|---|---|
4424–4448 | I don't really has an idea on how to combine this two with template function. Since depend clause in ordered is deprecated in 52, and will be removed, should we leave as this? | |
clang/lib/Sema/SemaOpenMP.cpp | ||
91 | Changed. Thanks. | |
11296–11332 | Not sure how to do this part. | |
11346–11359 | The code is for both Depend and Doacross with is really try to avoid copy-paste. | |
24033 | ActOnOpenMPDoacrossClauseCommon is added which called in |
clang/lib/Parse/ParseOpenMP.cpp | ||
---|---|---|
4424–4448 | Even ff it will be removed in 52, it will still stay for OpenMP < 52. Would be good to try to unify it. | |
clang/lib/Sema/SemaOpenMP.cpp | ||
20693–20699 | Better to create clauses in ActOnDoAcross and ActOnDepend, this function better to return required data as a struct/class/bolean, etc. | |
20700 | No need for else |
Thanks.
clang/lib/Parse/ParseOpenMP.cpp | ||
---|---|---|
4424–4448 | OKay thanks. Changed | |
clang/lib/Sema/SemaOpenMP.cpp | ||
11296–11332 | I just merged code into OMPC_depend. | |
20693–20699 | Okay I create static function instead. Thanks. |
clang/lib/Sema/SemaOpenMP.cpp | ||
---|---|---|
20871 | Remove this new line |
Can it be unified with depenbd clause parsing? (Maybe in a separate template function)