This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Use correct lowering for llvm.log2.f32
AbandonedPublic

Authored by arsenm on Jun 15 2023, 6:59 AM.

Details

Reviewers
foad
jhuber6
rampitec
Pierre-vh
cdevadas
Group Reviewers
Restricted Project
Summary

We previously directly codegened to v_log_f32, which is broken for
denormals. The lowering isn't complicated, you simply need to scale
denormal inputs and adjust the result. Note log and log10 are still
not accurate enough, and will be fixed separately.

Diff Detail

Event Timeline

arsenm created this revision.Jun 15 2023, 6:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 15 2023, 6:59 AM
arsenm requested review of this revision.Jun 15 2023, 6:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 15 2023, 6:59 AM
Herald added a subscriber: wdng. · View Herald Transcript

Is that different from D152766?

arsenm abandoned this revision.Jun 28 2023, 1:35 PM

Accidental repost