This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Canonicalize towards vid w/passthrough representation
ClosedPublic

Authored by reames on Jun 12 2023, 12:00 PM.

Details

Summary

This is a companion to D152380, and demonstrates the unsuffixed to _TA pseudo transition for a non-VMERGE case. Between the two of them, these should cover all the changes required to the post-ISEL combines, and other arithmetic-like instructions should be just TD changes.

See https://discourse.llvm.org/t/riscv-transition-in-vector-pseudo-structure-policy-variants/71295 for context on the patch series.

Diff Detail

Event Timeline

reames created this revision.Jun 12 2023, 12:00 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2023, 12:00 PM
reames requested review of this revision.Jun 12 2023, 12:00 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2023, 12:00 PM
reames edited the summary of this revision. (Show Details)Jun 12 2023, 12:24 PM
craig.topper added inline comments.Jun 13 2023, 2:22 PM
llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp
3247

Same formatting question from the other patch.

3382

I think the +1 should have spaces around the +?

craig.topper accepted this revision.Jun 13 2023, 2:29 PM

LGTM other than formatting comments

This revision is now accepted and ready to land.Jun 13 2023, 2:29 PM
This revision was landed with ongoing or failed builds.Jun 14 2023, 9:37 AM
This revision was automatically updated to reflect the committed changes.