Add lit test for Win

[aaron.ballman]

Thank you for this!

buildbot/osuosl/master/config/builders.py

919

Based on internal discussions, should we -DCMAKE_BUILD_TYPE=Debug so that we enable the checked STL functionality and get good stack traces when there are failures. Or are we going to stand up a different bot for that use case?

[yinyangsx]

• Add -DCMAKE_BUILD_TYPE=Debug option

[yinyangsx]

• Add -DCMAKE_BUILD_TYPE=Debug option

[yinyangsx]

• Add -DCMAKE_BUILD_TYPE=Debug option

[yinyangsx]

Update

[gkistanova]

Hi Yin,

Could you remove from this patch anything and everything unrelated to the change you are proposing, please?
Did you forget to rebase onto the HEAD?

[yinyangsx]

Hi, sorry for that, I am trying to move them but I not familiar with arc, so I need more time

[gkistanova]

No worries.
As another option, if you have a clean diff, you could use the WebUI to upload that. There is "Update Diff" link on the right top corner of this screen. Click that and follow the sequence of the pages. Maybe it would be easier?

[gkistanova]

Thanks for updating the patch!

It looks good with a couple of notes.

buildbot/osuosl/master/config/builders.py

905

-DLLVM_ENABLE_ASSERTIONS defaults to ON for Debug builds.

910

You do not need extra quotation marks around X86 here.

[yinyangsx]

Thank you! I have resolved the problem.

[yinyangsx]

Update

[gkistanova]

LGTM.

[yinyangsx]

hi Galina, Thank you a lot for your help, could you please land this patch?

[yinyangsx]

Update

[yinyangsx]

The last diff look like incorrect, I've made an update.

[aaron.ballman]

LGTM, thank you!!!

[gkistanova]

Apparently ClangBuilder does not support vs="autodetect" along with the test suite.

The problem is in these lines:

test_suite_env = copy.deepcopy(env)
test_suite_env['CC'] = cc
test_suite_env['CXX'] = cxx

In case of "autodetect" env is a build property, not a dictionary, and it does not support explicit assignments to CC and CXX.

I'll see if I can get some time to look into this issue over weekend or earlier next week. Please feel free to propose a patch if somebody else has some spare time to fix this issue, .

In the mean time, @aaron.ballman, could you revert this patch, please?

[aaron.ballman]

In D151980#4406274, @gkistanova wrote:

Apparently ClangBuilder does not support vs="autodetect" along with the test suite.

The problem is in these lines:

test_suite_env = copy.deepcopy(env)
test_suite_env['CC'] = cc
test_suite_env['CXX'] = cxx

In case of "autodetect" env is a build property, not a dictionary, and it does not support explicit assignments to CC and CXX.

I'll see if I can get some time to look into this issue over weekend or earlier next week. Please feel free to propose a patch if somebody else has some spare time to fix this issue, .

In the mean time, @aaron.ballman, could you revert this patch, please?

I've reverted in 14f85d830c9ba8eaabcc1f6d35e90c6fc995a173, thank you for catching this!

[yinyangsx]

• Add an MSVC debug x64 builder

[gkistanova]

Could you remove any and all unrelated changes from this patch, please?
What was wrong with the original approved patch?

[yinyangsx]

In D151980#4433344, @gkistanova wrote:

Could you remove any and all unrelated changes from this patch, please?
What was wrong with the original approved patch?

I created this patch by mistake. Could you please tell me how to close it?

[gkistanova]

This differential revision is referenced from the commit and is a part of the git history. So, you need to restore the diff to the original form which has been approved and committed.

There are multiple possible ways of doing so, the easiest, I think, is just download the raw diff from https://reviews.llvm.org/file/data/6esxbhtveros4tnrzliu/PHID-FILE-ygiily67vdz436p5gmmb/file, then click "Update Diff" here (top right part of the screen), and upload that saved diff.

Please let me know if you need a help with this.

Once the diff is updated to the correct one, leave this review as is without changing anything else.

[yinyangsx]

• Update LLDB Arm/AArch64 email notifier list
• Add an MSVC debug x64 builder

[aaron.ballman]

This looks to have picked up a bunch of unrelated changes again.

[yinyangsx]

I don't know why many changes has been submitted when I run "arc diff" and I can't delete these changes. So I created a new one to replace it, https://reviews.llvm.org/D154406

buildbot/osuosl/master/config/builders.py

                         "-DCOMPILER_RT_BUILD_SANITIZERS=OFF",
                         "-DLLVM_TARGETS_TO_BUILD='X86'"])},
 
+    ## Windows X86_64 AVX512 Clang+LLVM check-all + test-suite
+    {'name' : "clang-cmake-x86_64-avx512-win",
+    'tags'  : ["clang"],
+    'workernames' : ["avx512-intel64-win"],
+    'builddir': "clang-cmake-x86_64-avx512-win",
+    'factory' : ClangBuilder.getClangCMakeBuildFactory(
+                    vs="autodetect",
+                    clean=False,
+                    checkout_clang_tools_extra=False,
+                    checkout_compiler_rt=False,
+                    checkout_lld=False,
+                    useTwoStage=False,
+                    runTestSuite=True,
+                    testsuite_flags=['--cflag', '-march=cascadelake', '--threads=32', '--build-threads=32'],
+                    extra_cmake_args=[
+                        "-DCMAKE_BUILD_TYPE=Debug",
+                        "-DLLVM_ENABLE_ASSERTIONS=ON",
+                        "-DCMAKE_C_FLAGS='-march=cascadelake'",
+                        "-DCMAKE_CXX_FLAGS='-march=cascadelake'",
+                        "-DLLVM_ENABLE_RUNTIMES=compiler-rt",
+                        "-DCOMPILER_RT_BUILD_SANITIZERS=OFF",
+                        "-DLLVM_TARGETS_TO_BUILD='X86'"])},
+
     {'name' : "clang-xcore-ubuntu-20-x64",
     'tags'  : ["clang"],
     'workernames' : ["xcore-ubuntu20-x64"],

buildbot/osuosl/master/config/workers.py

         # X86_64 AVX512, Ubuntu 22.04.1 LTS, Intel(R) Xeon(R) Silver 4216 CPU @ 2.10GHz
         create_worker("avx512-intel64", properties={'jobs': 80}, max_builds=1),
 
+        # X86_64 AVX512, Windows Server 2022 Standard, Intel(R) Xeon(R) Silver 4216 CPU @ 2.10GHz
+        create_worker("avx512-intel64-win", properties={'jobs': 80}, max_builds=1),
+
         # Debian 9.0 x86_64 64-core GCE instances
         create_worker("fuchsia-debian-64-us-central1-a-1", properties={'jobs': 64}, max_builds=1),
         create_worker("fuchsia-debian-64-us-central1-b-1", properties={'jobs': 64}, max_builds=1),