For the SPE loads and store's (that requires 8 bit offest unlike others load and store instructions 16 bit offset)
Diff Detail
Diff Detail
Event Timeline
llvm/lib/Target/PowerPC/PPCFrameLowering.cpp | ||
---|---|---|
2304 | Not a fan of including a lambda in a conditional expression. It makes the expression as a whole harder to read. |
Comment Actions
removal of lambda expression from conditional statement, and updated existent test case.
Comment Actions
Thanks for dropping the lambda, it's now cleaner than my original patch as well. I know @sfertile asked me for a simpler test case, but I don't think it's really feasible.
Comment Actions
The asan test failure is unrelated to your change. You've got review approval so go ahead and land the change.
Not a fan of including a lambda in a conditional expression. It makes the expression as a whole harder to read.