Page MenuHomePhabricator

chmeee (Justin Hibbits)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 31 2014, 11:10 AM (264 w, 2 d)

Recent Activity

Feb 25 2018

chmeee added a comment to D38778: Implement rudimentary support for the PowerPC SPE APU.

I have a couple of questions (along with a nitpicky inline comment).

The e500 docs from Freescale specify e500v1 which supports basically everything added except for the efd* instructions and the various vector insts; e500v2 is required for efd* inst. / double support. They also have different scheduling models. It looks you're just implementing e500v2, should this be specified at all, or is the e500v1 not needed as a target?

Feb 25 2018, 5:34 PM

Feb 11 2018

chmeee added a comment to D38778: Implement rudimentary support for the PowerPC SPE APU.

Is there a Clang portion to follow? To define builtins for all the intrinsics in C/C++. Or do you not plan to target SPE from C/C++?

Feb 11 2018, 7:28 PM
chmeee added inline comments to D38778: Implement rudimentary support for the PowerPC SPE APU.
Feb 11 2018, 2:50 PM

Jan 14 2018

chmeee added a comment to D41702: Add SysV Abi for PPC64le.

@emaste, @jhibbits: do you know what's the state of ppc64 lldb support in freebsd?

It's broken because LLDB doesn't yet handle function descriptors, and I haven't yet made the effort (ENOTIME) to fix that. I think our eventual goal is to move even BE to ELFv2 on FreeBSD, to do away with function descriptors, and it should then Just Work, as powerpc (32-bit) works fine for most cases right now.

That said, if anyone knows enough to add function descriptor knowledge to LLDB, I think that's the only missing piece, or the biggest missing piece. I do want to finish the effort, since I started it 3.5 years ago, but I do need help with understanding that ABI detail and how it fits with LLDB.

Thanks for the explanation. How badly is it broken would you say? Do you think that using this ABI plugin for the big endian target (instead of the one from 2014) would make things any worse? Could you take a quick look to see if there is anything in this plugin that would be completely wrong for the big endian target ? (I couldn't find anything, apart from the obvious things like register constants in CreateDefaultUnwindPlan, but then again, I don't know the ABIs).

I'm trying to avoid making bad design decisions now because of legacy code that is known to be broken and has no clear maintainer nor a plan to fix it.

Jan 14 2018, 12:46 PM

Jan 5 2018

chmeee updated the diff for D38778: Implement rudimentary support for the PowerPC SPE APU.

Address most comments. I think tests are pretty complete now, and all bugs
found have been fixed. Removed selection for setcc on vectors.

Jan 5 2018, 8:32 PM

Dec 19 2017

chmeee added inline comments to D38778: Implement rudimentary support for the PowerPC SPE APU.
Dec 19 2017, 8:41 AM

Dec 15 2017

chmeee added inline comments to D38778: Implement rudimentary support for the PowerPC SPE APU.
Dec 15 2017, 12:43 PM

Nov 30 2017

chmeee added inline comments to D38778: Implement rudimentary support for the PowerPC SPE APU.
Nov 30 2017, 11:50 AM

Nov 28 2017

chmeee added a comment to D38778: Implement rudimentary support for the PowerPC SPE APU.

Thanks for the review. It is in need of more tests, I know.

Nov 28 2017, 7:44 PM

Nov 26 2017

chmeee updated the diff for D38778: Implement rudimentary support for the PowerPC SPE APU.

Correct e500 instruction scheduling.

Nov 26 2017, 1:25 PM

Nov 10 2017

chmeee added reviewers for D38778: Implement rudimentary support for the PowerPC SPE APU: kbarton, iteratee, sfertile, zatrazz.

Adding some more powerpc regulars in hopes of getting review. Feel free to remove yourself if you're not interested.

Nov 10 2017, 8:58 AM

Oct 29 2017

chmeee updated the summary of D38778: Implement rudimentary support for the PowerPC SPE APU.
Oct 29 2017, 6:22 PM
chmeee updated the diff for D38778: Implement rudimentary support for the PowerPC SPE APU.

Add patterns for intrinsics for codegen, and fix the intrinsic definitions.

Oct 29 2017, 6:17 PM

Oct 18 2017

chmeee updated the diff for D38778: Implement rudimentary support for the PowerPC SPE APU.

Add tests, add intrinsics (required for one test). Fix several bugs found via tests.

Oct 18 2017, 8:20 PM

Oct 11 2017

chmeee added a reviewer for D38778: Implement rudimentary support for the PowerPC SPE APU: echristo.
Oct 11 2017, 8:11 AM

Oct 10 2017

chmeee added a comment to D38778: Implement rudimentary support for the PowerPC SPE APU.

Tests are in the works right now. Until they're ready, this is a preliminary review, to see if I did anything unnecessary, or if I'm missing anything obvious.

Oct 10 2017, 8:34 PM
chmeee created D38778: Implement rudimentary support for the PowerPC SPE APU.
Oct 10 2017, 8:32 PM

Jan 22 2017

chmeee added inline comments to D29002: Add some Book-E instructions to the asm parser and printer..
Jan 22 2017, 8:33 PM
chmeee created D29002: Add some Book-E instructions to the asm parser and printer..
Jan 22 2017, 8:25 PM

Jul 2 2015

chmeee accepted D10698: Remove POSIX thread/process abstraction.

LGTM

Jul 2 2015, 11:32 PM