This is an archive of the discontinued LLVM Phabricator instance.

PowerPC/SPE: Grab the emergency slot for the vreg(that was created by the eliminateFramePointer)
ClosedPublic

Authored by long5hot on May 30 2023, 7:39 AM.

Details

Summary

For the SPE loads and store's (that requires 8 bit offest unlike others load and store instructions 16 bit offset)

PR : https://github.com/llvm/llvm-project/issues/62766

Diff Detail

Event Timeline

long5hot created this revision.May 30 2023, 7:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 30 2023, 7:39 AM
long5hot requested review of this revision.May 30 2023, 7:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 30 2023, 7:39 AM
jhibbits edited reviewers, added: jhibbits; removed: chmeee.May 30 2023, 9:54 AM
jhibbits added a subscriber: jhibbits.

This looks just like D78669, which I've admittedly been very lazy on.

This looks just like D78669, which I've admittedly been very lazy on.

@jhibbits can we land this commit to master please ...

jhibbits added inline comments.May 31 2023, 7:03 PM
llvm/lib/Target/PowerPC/PPCFrameLowering.cpp
2297

Not a fan of including a lambda in a conditional expression. It makes the expression as a whole harder to read.

long5hot updated this revision to Diff 527370.Jun 1 2023, 5:01 AM

removal of lambda expression from conditional statement, and updated existent test case.

@nemanjai ,Please can you help us to commit the changes .

long5hot updated this revision to Diff 541309.Jul 17 2023, 8:49 PM

Removin Lambda expression.

ping!

llvm/lib/Target/PowerPC/PPCFrameLowering.cpp
2297

got it!

jhibbits accepted this revision.Jul 18 2023, 6:20 AM

Thanks for dropping the lambda, it's now cleaner than my original patch as well. I know @sfertile asked me for a simpler test case, but I don't think it's really feasible.

This revision is now accepted and ready to land.Jul 18 2023, 6:20 AM

The asan test failure is unrelated to your change. You've got review approval so go ahead and land the change.

long5hot closed this revision.Jul 23 2023, 9:37 PM
llvm/lib/Target/PowerPC/PPCFrameLowering.cpp