[AST] Remove unused function removeLocalCVRQualifiers

[kazu]

Summary

The last use was removed by:

commit 0eb06cb3aa2700508c20da28f22ff91e7b82a436
Author: Roy Jacobson <[e-mail]>
Date:   Tue Mar 14 21:25:54 2023 +0200

[cor3ntin]

LGTM

[erichkeane]

Since this is part of the public API, do we need to publish/alert folks of this? This could perhaps be in use by someone using libclang/etc, right?

[kazu]

In D151607#4380757, @erichkeane wrote:

Since this is part of the public API, do we need to publish/alert folks of this? This could perhaps be in use by someone using libclang/etc, right?

I don't think we guarantee the API stability. For the *C* API, this is clearly documented:

https://llvm.org/docs/DeveloperPolicy.html#c-api-changes

There has been an effort to document something similar about the C++ API:

https://lists.llvm.org/pipermail/llvm-dev/2020-July/143613.html

but I don't know exactly what happened to it.

[aaron.ballman]

In D151607#4383132, @kazu wrote:

In D151607#4380757, @erichkeane wrote:

Since this is part of the public API, do we need to publish/alert folks of this? This could perhaps be in use by someone using libclang/etc, right?

I don't think we guarantee the API stability. For the *C* API, this is clearly documented:

https://llvm.org/docs/DeveloperPolicy.html#c-api-changes

There has been an effort to document something similar about the C++ API:

https://lists.llvm.org/pipermail/llvm-dev/2020-July/143613.html

but I don't know exactly what happened to it.

We try to keep the C API as stable as we can, but the C++ API is fair game to change as we need to. If someone runs into an issue where they need this functionality, they can let us know what their needs are and we can evaluate from there.

clang/include/clang/AST/Type.h

void addFastQualifiers(unsigned TQs) {
     assert(!(TQs & ~Qualifiers::FastMask)
            && "non-fast qualifier bits set in mask!");
     Value.setInt(Value.getInt() | TQs);
   }
 
   void removeLocalConst();
   void removeLocalVolatile();
   void removeLocalRestrict();
-  void removeLocalCVRQualifiers(unsigned Mask);
 
   void removeLocalFastQualifiers() { Value.setInt(0); }
   void removeLocalFastQualifiers(unsigned Mask) {
     assert(!(Mask & ~Qualifiers::FastMask) && "mask has non-fast qualifiers");
     Value.setInt(Value.getInt() & ~Mask);
   }
 
   // Creates a type with the given qualifiers in addition to any

 inline void QualType::removeLocalRestrict() {
   removeLocalFastQualifiers(Qualifiers::Restrict);
 }
 
 inline void QualType::removeLocalVolatile() {
   removeLocalFastQualifiers(Qualifiers::Volatile);
 }
 
-inline void QualType::removeLocalCVRQualifiers(unsigned Mask) {
-  assert(!(Mask & ~Qualifiers::CVRMask) && "mask has non-CVR bits");
-  static_assert((int)Qualifiers::CVRMask == (int)Qualifiers::FastMask,
-                "Fast bits differ from CVR bits!");
-
-  // Fast path: we don't need to touch the slow qualifiers.
-  removeLocalFastQualifiers(Mask);
-}
-
 /// Check if this type has any address space qualifier.
 inline bool QualType::hasAddressSpace() const {
   return getQualifiers().hasAddressSpace();
 }
 
 /// Return the address space of this type.
 inline LangAS QualType::getAddressSpace() const {
   return getQualifiers().getAddressSpace();