Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[clang-tidy] Improve build-in type handling in bugprone-swapped-arguments
ClosedPublic

Authored by PiotrZSL on May 25 2023, 1:59 PM.

Details

Summary

Improved detection of argument swaps involving integral and floating-point
types by enhancing handling of implicit conversions. Now implicit casts
from float to double are also considered, same for integers.
Improved documentation.

Fixes: #62926

Diff Detail

Event Timeline

PiotrZSL created this revision.May 25 2023, 1:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 25 2023, 1:59 PM
Herald added a subscriber: xazax.hun. · View Herald Transcript
PiotrZSL requested review of this revision.May 25 2023, 1:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 25 2023, 1:59 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
carlosgalvezp accepted this revision.Jul 16 2023, 10:20 AM

LGTM, thank you for the fix!

This revision is now accepted and ready to land.Jul 16 2023, 10:20 AM