This is an archive of the discontinued LLVM Phabricator instance.

[NFC][Py Reformat] Reformat python files in lldb
ClosedPublic

Authored by JDevlieghere on May 25 2023, 8:52 AM.

Details

Summary

This is an ongoing series of commits that are reformatting our Python
code. Reformatting is done with black.

If you end up having problems merging this commit because you have made
changes to a python file, the best way to handle that is to run `git
checkout --ours <yourfile>` and then reformat it with black.

RFC: https://discourse.llvm.org/t/rfc-document-and-standardize-python-code-style

Diff Detail

Event Timeline

JDevlieghere created this revision.May 25 2023, 8:52 AM
JDevlieghere requested review of this revision.May 25 2023, 8:52 AM
thieta accepted this revision.May 25 2023, 9:02 AM

Thanks for doing this! Going to assume you ran the tests and it worked :)

This revision is now accepted and ready to land.May 25 2023, 9:02 AM

Thanks for doing this! Going to assume you ran the tests and it worked :)

Yup, no regressions. I'll keep an eye on the bots to make sure that holds true for other configurations too.

mib added a subscriber: mib.May 25 2023, 9:17 AM

Can you add this commit hash to the .git-blame-ignore-revs file so it doesn't show up in the git history

Can you add this commit hash to the .git-blame-ignore-revs file so it doesn't show up in the git history

Yeah that should be done. But has to be done after arc land anyway.

Can you add this commit hash to the .git-blame-ignore-revs file so it doesn't show up in the git history

Yeah that should be done. But has to be done after arc land anyway.

Yup, but as Tobias pointed it needs to be committed first in order to get the hash.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 25 2023, 12:54 PM