This is an archive of the discontinued LLVM Phabricator instance.

[AIX] make integrated-as as default on AIX.
ClosedPublic

Authored by Esme on May 17 2023, 12:16 AM.

Details

Summary

Clang uses LLVM’s integrated assembler by default on most targets, however non-integrated-as mode is default on AIX.
Currently integrated-as mode on AIX has passed tests of LLVM test-suite, bootstrap and Spec2017, therefore this patch sets integrated-as as the default assembler mode on AIX.

Diff Detail

Event Timeline

Esme created this revision.May 17 2023, 12:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2023, 12:16 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
Esme requested review of this revision.May 17 2023, 12:16 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 17 2023, 12:16 AM
Esme edited the summary of this revision. (Show Details)May 17 2023, 12:27 AM
Esme edited the summary of this revision. (Show Details)
brad added a subscriber: brad.May 17 2023, 7:06 PM
brad added inline comments.
llvm/lib/MC/MCAsmInfoXCOFF.cpp
55 ↗(On Diff #522919)

Instead of setting the value to true you can just remove the line all together.

shchenz added inline comments.May 17 2023, 10:32 PM
llvm/lib/MC/MCAsmInfoXCOFF.cpp
55 ↗(On Diff #522919)

+1

And maybe this default value change can be put into another patch, as this is for backend?

Esme updated this revision to Diff 524641.May 23 2023, 3:46 AM

Separate the backend changes from this patch.

DiggerLin added inline comments.May 29 2023, 1:27 PM
clang/test/Driver/aix-integrated-as.c
10

both -fno-integrated-as and -fintegrated-as output the same file name "aix-integrated-as.o" , do you want to check "aix-integrated-as.o" here

18

ditto

Esme updated this revision to Diff 526545.May 30 2023, 1:38 AM

Remove unnecessary check lines.

Esme added inline comments.May 30 2023, 1:40 AM
clang/test/Driver/aix-integrated-as.c
10

Thanks, it seems an unnecessary check.

DiggerLin accepted this revision.May 30 2023, 7:05 AM
This revision is now accepted and ready to land.May 30 2023, 7:05 AM
Esme updated this revision to Diff 534884.Jun 27 2023, 2:43 AM

Rebase.

This revision was landed with ongoing or failed builds.Jul 6 2023, 12:17 AM
This revision was automatically updated to reflect the committed changes.