Page MenuHomePhabricator

qiongsiwu1 (Qiongsi Wu)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 7 2021, 8:18 AM (68 w, 22 h)

Recent Activity

Dec 15 2022

qiongsiwu1 added a comment to D140080: [clang][PPC] Supporting -mcpu=405.

The pre-commit CI crashes do not seem to relate to this patch. I will land it soon.

Dec 15 2022, 7:26 AM · Restricted Project, Restricted Project, Restricted Project
qiongsiwu1 updated the diff for D140080: [clang][PPC] Supporting -mcpu=405.

Addressing review comments. Thanks for the review @nemanjai !!

Dec 15 2022, 5:47 AM · Restricted Project, Restricted Project, Restricted Project

Dec 14 2022

qiongsiwu1 updated the diff for D140080: [clang][PPC] Supporting -mcpu=405.
Dec 14 2022, 6:39 PM · Restricted Project, Restricted Project, Restricted Project
qiongsiwu1 updated the summary of D140080: [clang][PPC] Supporting -mcpu=405.
Dec 14 2022, 6:25 PM · Restricted Project, Restricted Project, Restricted Project
qiongsiwu1 updated the summary of D140080: [clang][PPC] Supporting -mcpu=405.
Dec 14 2022, 6:23 PM · Restricted Project, Restricted Project, Restricted Project
qiongsiwu1 requested review of D140080: [clang][PPC] Supporting -mcpu=405.
Dec 14 2022, 6:20 PM · Restricted Project, Restricted Project, Restricted Project

Dec 12 2022

qiongsiwu1 added a comment to D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu.

I'm fine with handling the return for common as a separate change, if necessary.

Dec 12 2022, 12:26 PM · Restricted Project, Restricted Project
qiongsiwu1 added inline comments to D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu.
Dec 12 2022, 8:26 AM · Restricted Project, Restricted Project
qiongsiwu1 updated the diff for D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu.

Updating to revert back to const char * in the big StringSwitch.

Dec 12 2022, 8:21 AM · Restricted Project, Restricted Project
qiongsiwu1 added inline comments to D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu.
Dec 12 2022, 6:36 AM · Restricted Project, Restricted Project

Dec 9 2022

qiongsiwu1 updated the summary of D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu.
Dec 9 2022, 2:14 PM · Restricted Project, Restricted Project
qiongsiwu1 updated the diff for D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu.

Update to include a new test case against the unknown target error message. Thanks for the suggestion @amyk !

Dec 9 2022, 1:42 PM · Restricted Project, Restricted Project
qiongsiwu1 added reviewers for D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu: daltenty, jamieschmeiser.
Dec 9 2022, 8:56 AM · Restricted Project, Restricted Project
qiongsiwu1 requested review of D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu.
Dec 9 2022, 8:26 AM · Restricted Project, Restricted Project

Dec 5 2022

qiongsiwu1 abandoned D139343: [Driver][PPC] Support -mtune=auto.

It is decided that we no longer need this patch.

Dec 5 2022, 10:41 AM · Restricted Project, Restricted Project, Restricted Project
qiongsiwu1 requested review of D139343: [Driver][PPC] Support -mtune=auto.
Dec 5 2022, 9:32 AM · Restricted Project, Restricted Project, Restricted Project

Nov 29 2022

qiongsiwu1 updated the diff for D138854: [AIX][LTO] Enabling Context Sensitive PGO Options.

Fix a clang-format issue in CommonArgs.cpp.

Nov 29 2022, 11:29 AM · Restricted Project, Restricted Project, Restricted Project
qiongsiwu1 updated the diff for D138854: [AIX][LTO] Enabling Context Sensitive PGO Options.

Address review comment. Thanks for the review!

Nov 29 2022, 7:44 AM · Restricted Project, Restricted Project, Restricted Project

Nov 28 2022

qiongsiwu1 added a comment to D138585: [SLPVectorizer] Do Not Move Loads/Stores Beyond Stacksave/Stackrestore Boundaries.

Can you explain why memory dependence wasn't enough to prevent the problematic reordering? I'm a bit fuzzy on the details - it's been a while - but I though that stacksave and stackrestore were modeled as modifying all memory to prevent this reordering?

Nov 28 2022, 5:49 PM · Restricted Project, Restricted Project
qiongsiwu1 requested review of D138854: [AIX][LTO] Enabling Context Sensitive PGO Options.
Nov 28 2022, 12:33 PM · Restricted Project, Restricted Project, Restricted Project
qiongsiwu1 added a comment to D138585: [SLPVectorizer] Do Not Move Loads/Stores Beyond Stacksave/Stackrestore Boundaries.

@ABataev Thanks so much for the fast review! I will land the patch in a moment.

Nov 28 2022, 6:21 AM · Restricted Project, Restricted Project
qiongsiwu1 added a comment to D138585: [SLPVectorizer] Do Not Move Loads/Stores Beyond Stacksave/Stackrestore Boundaries.

Ping for review. @reames could you also let me know if I should tag anyone else for a review? Thanks so much!

Nov 28 2022, 5:20 AM · Restricted Project, Restricted Project

Nov 25 2022

qiongsiwu1 requested review of D138729: [AIX][LTO] Teaching lto-aix-system-assembler Relative Path and Tilde Resolution.
Nov 25 2022, 9:26 AM · Restricted Project, Restricted Project

Nov 23 2022

qiongsiwu1 updated the diff for D138585: [SLPVectorizer] Do Not Move Loads/Stores Beyond Stacksave/Stackrestore Boundaries.
Nov 23 2022, 2:54 PM · Restricted Project, Restricted Project
qiongsiwu1 updated the diff for D138585: [SLPVectorizer] Do Not Move Loads/Stores Beyond Stacksave/Stackrestore Boundaries.

Updating code comment.

Nov 23 2022, 2:53 PM · Restricted Project, Restricted Project
qiongsiwu1 updated the summary of D138585: [SLPVectorizer] Do Not Move Loads/Stores Beyond Stacksave/Stackrestore Boundaries.
Nov 23 2022, 9:25 AM · Restricted Project, Restricted Project
qiongsiwu1 updated the summary of D138585: [SLPVectorizer] Do Not Move Loads/Stores Beyond Stacksave/Stackrestore Boundaries.
Nov 23 2022, 9:11 AM · Restricted Project, Restricted Project
qiongsiwu1 requested review of D138585: [SLPVectorizer] Do Not Move Loads/Stores Beyond Stacksave/Stackrestore Boundaries.
Nov 23 2022, 9:08 AM · Restricted Project, Restricted Project

Oct 27 2022

qiongsiwu1 requested review of D136874: [clang][LTO] Passing vec-extabi to the Backend on AIX.
Oct 27 2022, 12:05 PM · Restricted Project, Restricted Project

Oct 20 2022

qiongsiwu1 updated the diff for D135885: [clang][LTO][NFC] Adding More Tests for AIX Options.

Rebase and cleanup some test cases.

Oct 20 2022, 5:33 PM · Restricted Project, Restricted Project
qiongsiwu1 added inline comments to D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option.
Oct 20 2022, 9:40 AM · Restricted Project, debug-info, Restricted Project
qiongsiwu1 added inline comments to D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option.
Oct 20 2022, 7:17 AM · Restricted Project, debug-info, Restricted Project
qiongsiwu1 updated the diff for D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option.

Adding two test cases to match G_NOTUNING.

Oct 20 2022, 7:17 AM · Restricted Project, debug-info, Restricted Project

Oct 19 2022

qiongsiwu1 updated the diff for D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option.

Address the review comment.

Oct 19 2022, 7:52 AM · Restricted Project, debug-info, Restricted Project

Oct 18 2022

qiongsiwu1 updated the summary of D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option.
Oct 18 2022, 11:21 AM · Restricted Project, debug-info, Restricted Project
qiongsiwu1 updated the summary of D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option.
Oct 18 2022, 11:21 AM · Restricted Project, debug-info, Restricted Project
qiongsiwu1 updated the diff for D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option.

Adding one more test case.

Oct 18 2022, 11:01 AM · Restricted Project, debug-info, Restricted Project
qiongsiwu1 requested review of D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option.
Oct 18 2022, 10:50 AM · Restricted Project, debug-info, Restricted Project
qiongsiwu1 added a comment to D135885: [clang][LTO][NFC] Adding More Tests for AIX Options.

@w2yehia @daltenty may I ask for a review? Thanks so much!

Oct 18 2022, 6:53 AM · Restricted Project, Restricted Project
qiongsiwu1 updated the diff for D135908: [clang][LTO] Setting Desired Default AIX Debugging Options.

Address a review comment.

Oct 18 2022, 6:50 AM · Restricted Project, Restricted Project

Oct 17 2022

qiongsiwu1 updated the diff for D135908: [clang][LTO] Setting Desired Default AIX Debugging Options.

Clean up test cases.

Oct 17 2022, 2:59 PM · Restricted Project, Restricted Project
qiongsiwu1 added inline comments to D135908: [clang][LTO] Setting Desired Default AIX Debugging Options.
Oct 17 2022, 1:58 PM · Restricted Project, Restricted Project
qiongsiwu1 updated the diff for D135908: [clang][LTO] Setting Desired Default AIX Debugging Options.

Address code review.

Oct 17 2022, 1:56 PM · Restricted Project, Restricted Project
qiongsiwu1 updated subscribers of D135843: [AArch64][NFC][1/4]Refactor 'isBitfieldPositioningOp' so that DAG nodes with different Opcode are handled with separate helper functions.

Ah I just saw 5d3139aef113881fff9430c96069faf96630a5d8. Thanks @MaskRay !

Oct 17 2022, 10:10 AM · Restricted Project, Restricted Project
qiongsiwu1 added a comment to D135908: [clang][LTO] Setting Desired Default AIX Debugging Options.
Oct 17 2022, 10:10 AM · Restricted Project, Restricted Project
qiongsiwu1 added a comment to D135843: [AArch64][NFC][1/4]Refactor 'isBitfieldPositioningOp' so that DAG nodes with different Opcode are handled with separate helper functions.

This patch seems to be causing build failures when a build is configured with -Werror due to the warnings (e.g. https://lab.llvm.org/buildbot/#/builders/57/builds/22957). May I get your help @mingmingl for some advices/fixes to get the build going? Thank you!

Oct 17 2022, 10:01 AM · Restricted Project, Restricted Project

Oct 13 2022

qiongsiwu1 requested review of D135908: [clang][LTO] Setting Desired Default AIX Debugging Options.
Oct 13 2022, 12:26 PM · Restricted Project, Restricted Project
qiongsiwu1 requested review of D135885: [clang][LTO][NFC] Adding More Tests for AIX Options.
Oct 13 2022, 8:31 AM · Restricted Project, Restricted Project

Oct 12 2022

qiongsiwu1 updated the diff for D134820: [LTO][clang] Teaching Clang to Pass Plugin Options to the AIX Linker.

Rebase with latest main.

Oct 12 2022, 6:32 AM · Restricted Project, Restricted Project

Oct 6 2022

qiongsiwu1 updated the diff for D135400: [clang][LTO] Remove the use of `--` for arange option .

Thanks for the review! Comment addressed.

Oct 6 2022, 3:36 PM · Restricted Project, Restricted Project, Restricted Project
qiongsiwu1 added a comment to D134668: [LTO][clang] Using Single Dash Consistently when Passing LTO Options.

Err since -plugin-opt= was used a lot of before this change, I think this is fine for consistency.

Oct 6 2022, 3:16 PM · Restricted Project, Restricted Project
qiongsiwu1 added a comment to D135400: [clang][LTO] Remove the use of `--` for arange option .

I missed https://reviews.llvm.org/D134668 . See my comment there I don't think the change is necessary.

Oct 6 2022, 2:22 PM · Restricted Project, Restricted Project, Restricted Project
qiongsiwu1 added a comment to D134668: [LTO][clang] Using Single Dash Consistently when Passing LTO Options.

I think I want to revert this change. --plugin-opt= is entirely fine with lld and GNU gold/ld... And generally the double-dash long options are preferred.

Oct 6 2022, 2:20 PM · Restricted Project, Restricted Project
qiongsiwu1 updated the summary of D135400: [clang][LTO] Remove the use of `--` for arange option .
Oct 6 2022, 2:08 PM · Restricted Project, Restricted Project, Restricted Project
qiongsiwu1 removed a project from D135400: [clang][LTO] Remove the use of `--` for arange option : Restricted Project.
Oct 6 2022, 2:06 PM · Restricted Project, Restricted Project, Restricted Project
qiongsiwu1 updated the diff for D135400: [clang][LTO] Remove the use of `--` for arange option .

Fix a patch upload error.

Oct 6 2022, 2:06 PM · Restricted Project, Restricted Project, Restricted Project
qiongsiwu1 requested review of D135400: [clang][LTO] Remove the use of `--` for arange option .
Oct 6 2022, 2:04 PM · Restricted Project, Restricted Project, Restricted Project

Oct 4 2022

qiongsiwu1 added a reviewer for D134820: [LTO][clang] Teaching Clang to Pass Plugin Options to the AIX Linker: daltenty.
Oct 4 2022, 11:32 AM · Restricted Project, Restricted Project
qiongsiwu1 updated the diff for D134820: [LTO][clang] Teaching Clang to Pass Plugin Options to the AIX Linker.

Address review comments. Remove unnecessary Twines.

Oct 4 2022, 7:11 AM · Restricted Project, Restricted Project

Oct 3 2022

qiongsiwu1 updated the diff for D134820: [LTO][clang] Teaching Clang to Pass Plugin Options to the AIX Linker.

Address a code review comment.

Oct 3 2022, 7:31 AM · Restricted Project, Restricted Project

Sep 29 2022

qiongsiwu1 updated the diff for D134820: [LTO][clang] Teaching Clang to Pass Plugin Options to the AIX Linker.

Try fixing the test case on Windows, hopefully one last time.

Sep 29 2022, 12:54 PM · Restricted Project, Restricted Project
qiongsiwu1 updated the diff for D134820: [LTO][clang] Teaching Clang to Pass Plugin Options to the AIX Linker.

Fix test case on Windows.

Sep 29 2022, 9:48 AM · Restricted Project, Restricted Project
qiongsiwu1 updated the diff for D134820: [LTO][clang] Teaching Clang to Pass Plugin Options to the AIX Linker.

Fix the test failure on Windows.

Sep 29 2022, 6:48 AM · Restricted Project, Restricted Project

Sep 28 2022

qiongsiwu1 updated the summary of D134820: [LTO][clang] Teaching Clang to Pass Plugin Options to the AIX Linker.
Sep 28 2022, 12:16 PM · Restricted Project, Restricted Project
qiongsiwu1 requested review of D134820: [LTO][clang] Teaching Clang to Pass Plugin Options to the AIX Linker.
Sep 28 2022, 11:59 AM · Restricted Project, Restricted Project
qiongsiwu1 updated the diff for D134375: [LTO][AIX] Invoking AIX System Assembler in LTO CodeGen.

Addressing code review comments and fixing a test failure on Linux. I will land patch once the pre-commit CI finishes.

Sep 28 2022, 7:35 AM · Restricted Project, Restricted Project

Sep 27 2022

qiongsiwu1 updated the diff for D134375: [LTO][AIX] Invoking AIX System Assembler in LTO CodeGen.

Addressing code review comments.

Sep 27 2022, 6:54 AM · Restricted Project, Restricted Project

Sep 26 2022

qiongsiwu1 updated the summary of D134668: [LTO][clang] Using Single Dash Consistently when Passing LTO Options.
Sep 26 2022, 12:47 PM · Restricted Project, Restricted Project
qiongsiwu1 updated the summary of D134668: [LTO][clang] Using Single Dash Consistently when Passing LTO Options.
Sep 26 2022, 12:46 PM · Restricted Project, Restricted Project
qiongsiwu1 requested review of D134668: [LTO][clang] Using Single Dash Consistently when Passing LTO Options.
Sep 26 2022, 12:44 PM · Restricted Project, Restricted Project
qiongsiwu1 added a comment to D134375: [LTO][AIX] Invoking AIX System Assembler in LTO CodeGen.

Gentle ping for review. Thanks!

Sep 26 2022, 5:24 AM · Restricted Project, Restricted Project

Sep 22 2022

qiongsiwu1 updated the diff for D134375: [LTO][AIX] Invoking AIX System Assembler in LTO CodeGen.

Updating function names so they are more explicit.

Sep 22 2022, 6:09 AM · Restricted Project, Restricted Project
qiongsiwu1 updated the diff for D134375: [LTO][AIX] Invoking AIX System Assembler in LTO CodeGen.

Minor formatting update.

Sep 22 2022, 5:49 AM · Restricted Project, Restricted Project
qiongsiwu1 updated the diff for D134375: [LTO][AIX] Invoking AIX System Assembler in LTO CodeGen.

Addressing code review:

Sep 22 2022, 5:47 AM · Restricted Project, Restricted Project

Sep 21 2022

qiongsiwu1 updated the diff for D134375: [LTO][AIX] Invoking AIX System Assembler in LTO CodeGen.

Update the diff to include the context.

Sep 21 2022, 10:53 AM · Restricted Project, Restricted Project
qiongsiwu1 updated the summary of D134375: [LTO][AIX] Invoking AIX System Assembler in LTO CodeGen.
Sep 21 2022, 10:26 AM · Restricted Project, Restricted Project
qiongsiwu1 requested review of D134375: [LTO][AIX] Invoking AIX System Assembler in LTO CodeGen.
Sep 21 2022, 10:23 AM · Restricted Project, Restricted Project

Jul 28 2022

qiongsiwu1 added a comment to D130107: MemoryBuiltins: remove malloc-family funcs from list.

Does that help?

Jul 28 2022, 7:37 AM · Restricted Project, Restricted Project
qiongsiwu1 added a comment to D130107: MemoryBuiltins: remove malloc-family funcs from list.

May I ask for some guidance/example on how to use the attributes to identify that the removed functions (e.g. malloc, calloc, realloc) are still allocation functions?

Jul 28 2022, 7:00 AM · Restricted Project, Restricted Project

May 20 2022

qiongsiwu1 committed rG1f12718ccfd6: [clang] Fixing arm-common, windows only and openmp header install targets (authored by qiongsiwu1).
[clang] Fixing arm-common, windows only and openmp header install targets
May 20 2022, 9:30 AM · Restricted Project, Restricted Project
qiongsiwu1 closed D126002: [clang] Fixing arm-common, windows only and openmp header install targets.
May 20 2022, 9:29 AM · Restricted Project, Restricted Project

May 19 2022

qiongsiwu1 added inline comments to D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets.
May 19 2022, 11:52 AM · Restricted Project, Restricted Project
qiongsiwu1 added inline comments to D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets.
May 19 2022, 11:51 AM · Restricted Project, Restricted Project
qiongsiwu1 requested review of D126002: [clang] Fixing arm-common, windows only and openmp header install targets.
May 19 2022, 11:50 AM · Restricted Project, Restricted Project

May 12 2022

qiongsiwu1 added a comment to D125482: [LLVM][Casting.h] Don't create a temporary while casting..

@qiongsiwu1 I assume you ran the whole test suite with no problems? My machine is rather slow so running check-all takes ~many hours for me

Good call - no I did not run the whole test suite. I did run ninja check-all. Let me give the test suite a try as well.

That's what I meant. I think build kite is running ninja check-clang-tools check-bolt check-mlir check-flang check-all check-lld check-openmp check-clang check-polly check-libc check-llvm

build kite is being flaky right now so I'd love a clean bill of health before landing to unblock folks.

Ah I see. I tested check-all, but I did not build flang/openmp/polly/libc for my local testing. Let me give those a go instead of running the "test-suite".

Many thanks - I assume your build machine is better than mine :)

I got check-clang and check-llvm on my machine and both are all good (which is usually a good sign)

May 12 2022, 5:22 PM · Restricted Project, Restricted Project
qiongsiwu1 added a comment to D125482: [LLVM][Casting.h] Don't create a temporary while casting..

@qiongsiwu1 I assume you ran the whole test suite with no problems? My machine is rather slow so running check-all takes ~many hours for me

Good call - no I did not run the whole test suite. I did run ninja check-all. Let me give the test suite a try as well.

That's what I meant. I think build kite is running ninja check-clang-tools check-bolt check-mlir check-flang check-all check-lld check-openmp check-clang check-polly check-libc check-llvm

build kite is being flaky right now so I'd love a clean bill of health before landing to unblock folks.

May 12 2022, 4:36 PM · Restricted Project, Restricted Project
qiongsiwu1 added a comment to D125482: [LLVM][Casting.h] Don't create a temporary while casting..

@qiongsiwu1 I assume you ran the whole test suite with no problems? My machine is rather slow so running check-all takes ~many hours for me

May 12 2022, 4:33 PM · Restricted Project, Restricted Project
qiongsiwu1 accepted D125482: [LLVM][Casting.h] Don't create a temporary while casting..

LGTM! Thanks!

May 12 2022, 4:17 PM · Restricted Project, Restricted Project
qiongsiwu1 added a comment to D125482: [LLVM][Casting.h] Don't create a temporary while casting..

@qiongsiwu1 or @uabelho please let me know if this fixes the issue you saw. I don't think I see the warning emitted anywhere I was able to repro.

May 12 2022, 12:32 PM · Restricted Project, Restricted Project
qiongsiwu1 added inline comments to D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets.
May 12 2022, 9:52 AM · Restricted Project, Restricted Project
qiongsiwu1 updated subscribers of D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..

from
https://lab.llvm.org/buildbot/#/builders/57/builds/17829/steps/6/logs/stdio

I see the same thing compiling locally with clang 8.

May 12 2022, 7:32 AM · Restricted Project, Restricted Project
qiongsiwu1 added inline comments to D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets.
May 12 2022, 5:48 AM · Restricted Project, Restricted Project

May 11 2022

qiongsiwu1 committed rG3ca6328637b3: [clang][ppc] Creating Seperate Install Target for PPC htm Headers (authored by qiongsiwu1).
[clang][ppc] Creating Seperate Install Target for PPC htm Headers
May 11 2022, 11:53 AM · Restricted Project, Restricted Project
qiongsiwu1 closed D125386: [clang][ppc] Creating Seperate Install Target for PPC htm Headers.
May 11 2022, 11:53 AM · Restricted Project, Restricted Project, Restricted Project
qiongsiwu1 added a reviewer for D125386: [clang][ppc] Creating Seperate Install Target for PPC htm Headers: hubert.reinterpretcast.
May 11 2022, 6:43 AM · Restricted Project, Restricted Project, Restricted Project
qiongsiwu1 requested review of D125386: [clang][ppc] Creating Seperate Install Target for PPC htm Headers.
May 11 2022, 6:42 AM · Restricted Project, Restricted Project, Restricted Project

Apr 28 2022

qiongsiwu1 updated the diff for D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets.

This patch is updated to address

Apr 28 2022, 8:03 AM · Restricted Project, Restricted Project

Apr 23 2022

qiongsiwu1 added a comment to D123943: MachineModuleInfo: Move AddrLabelSymbols to AsmPrinter.

Hi Matt @arsenm !

May I check with you why commit https://reviews.llvm.org/rG9209a519180b478f7a77d7c4781ea857536d77ed does not have a link to this patch?

Thanks!!

FYI @zibi

I don't use arc which adds those comments

Apr 23 2022, 10:28 AM · Restricted Project, Restricted Project

Apr 21 2022

qiongsiwu1 added a comment to D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets.

Hi, this patch causes an issue with the CMake Xcode build configuration, if I try to use xcode as the generator with CMake, using the build command:

I used git bisect to figure this out, is there some solution to this?

Apr 21 2022, 10:43 AM · Restricted Project, Restricted Project
qiongsiwu1 updated subscribers of D123943: MachineModuleInfo: Move AddrLabelSymbols to AsmPrinter.

Hi Matt @arsenm !

Apr 21 2022, 10:37 AM · Restricted Project, Restricted Project