- User Since
- Oct 7 2021, 8:18 AM (68 w, 22 h)
Dec 15 2022
The pre-commit CI crashes do not seem to relate to this patch. I will land it soon.
Addressing review comments. Thanks for the review @nemanjai !!
Dec 14 2022
Dec 12 2022
Updating to revert back to const char * in the big StringSwitch.
Dec 9 2022
Update to include a new test case against the unknown target error message. Thanks for the suggestion @amyk !
Dec 5 2022
It is decided that we no longer need this patch.
Nov 29 2022
Fix a clang-format issue in CommonArgs.cpp.
Address review comment. Thanks for the review!
Nov 28 2022
@ABataev Thanks so much for the fast review! I will land the patch in a moment.
Ping for review. @reames could you also let me know if I should tag anyone else for a review? Thanks so much!
Nov 25 2022
Nov 23 2022
Updating code comment.
Oct 27 2022
Oct 20 2022
Rebase and cleanup some test cases.
Adding two test cases to match G_NOTUNING.
Oct 19 2022
Address the review comment.
Oct 18 2022
Adding one more test case.
Address a review comment.
Oct 17 2022
Clean up test cases.
Address code review.
This patch seems to be causing build failures when a build is configured with -Werror due to the warnings (e.g. https://lab.llvm.org/buildbot/#/builders/57/builds/22957). May I get your help @mingmingl for some advices/fixes to get the build going? Thank you!
Oct 13 2022
Oct 12 2022
Rebase with latest main.
Oct 6 2022
Thanks for the review! Comment addressed.
Fix a patch upload error.
Oct 4 2022
Address review comments. Remove unnecessary Twines.
Oct 3 2022
Address a code review comment.
Sep 29 2022
Try fixing the test case on Windows, hopefully one last time.
Fix test case on Windows.
Fix the test failure on Windows.
Sep 28 2022
Addressing code review comments and fixing a test failure on Linux. I will land patch once the pre-commit CI finishes.
Sep 27 2022
Addressing code review comments.
Sep 26 2022
Gentle ping for review. Thanks!
Sep 22 2022
Updating function names so they are more explicit.
Minor formatting update.
Addressing code review:
Sep 21 2022
Update the diff to include the context.
Jul 28 2022
Does that help?
May I ask for some guidance/example on how to use the attributes to identify that the removed functions (e.g. malloc, calloc, realloc) are still allocation functions?
May 20 2022
May 19 2022
May 12 2022
May 11 2022
Apr 28 2022
This patch is updated to address
Apr 23 2022
Apr 21 2022
Hi Matt @arsenm !