SM80 flag guards the test for targets that do not support A100 GPUs
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Do we have tests that require a specific architecture available (things like AVX512 or other fancy things) that we can model against?
When I added e.g. the AMX test, I added a new configuration for that
if not config.mlir_run_amx_tests: config.unsupported = True
which can be controlled from the setup through DMLIR_RUN_AMX_TESTS.
I can do the same here, of course, but I was really hoping that something like this was already there.
Seems like I am always the first to actually run these things ;-)
Thomas suggests perhaps we should upgrade the bots from turing to ampere ;-)
But until that time, I will add a build flag for these tests.
Any preference for the name?
mlir/test/Integration/Dialect/SparseTensor/GPU/CUDA/sparse-mma-2-4-f16.mlir | ||
---|---|---|
13 | ditto |
Bah, phabricator didn't save the comment I was referring to with that "ditto". So here it is again:
mlir/test/Integration/Dialect/SparseTensor/GPU/CUDA/sparse-matvec.mlir | ||
---|---|---|
10 | Maybe this note should be on the first line, so users see it before all the RUN stuff? |
mlir/test/Integration/Dialect/SparseTensor/GPU/CUDA/lit.local.cfg | ||
---|---|---|
3 | Do we plan to not ever have tests in this folder that would run on a <sm80 GPU? (otherwise we should use a REQUIRE annotation in the tests themselves instead) |
mlir/test/Integration/Dialect/SparseTensor/GPU/CUDA/lit.local.cfg | ||
---|---|---|
3 | Good question, but I am not sure of the answer (yet), since GPU support for the sparse compiler and in particular specifically for CUDA is just ramping up. Perhaps we want to target lower versions too as some point. But I made a note of your suggestion to reconsider when we have more visibility in what targets we will converge on... |
Do we plan to not ever have tests in this folder that would run on a <sm80 GPU? (otherwise we should use a REQUIRE annotation in the tests themselves instead)