This is an archive of the discontinued LLVM Phabricator instance.

Differential D147583

Fix bazel overlay after "[mlir] Introduce IRDL dialect"
ClosedPublic

Authored by tlongeri on Apr 4 2023, 4:50 PM.

Details

Reviewers
mehdi_amini
rdzhabarov
dblaikie
Commits
rG71401f0f98f4: Fix bazel overlay after "[mlir] Introduce IRDL dialect"

Diff Detail

Event Timeline

tlongeri created this revision.Apr 4 2023, 4:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2023, 4:50 PM
Herald added subscribers: Moerafaat, zero9178, bzcheeseman and 21 others. · View Herald Transcript
tlongeri requested review of this revision.Apr 4 2023, 4:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2023, 4:50 PM
Herald added subscribers: llvm-commits, stephenneuendorffer, nicolasvasilache. · View Herald Transcript
tlongeri updated this revision to Diff 510967.Apr 4 2023, 4:55 PM

Fix whitespace

tlongeri updated this revision to Diff 510968.Apr 4 2023, 4:57 PM

More fix whitespace

Harbormaster completed remote builds in B223703: Diff 510968.Apr 4 2023, 5:01 PM
tlongeri updated this revision to Diff 510974.Apr 4 2023, 5:29 PM

Fix missing deps

Harbormaster completed remote builds in B223709: Diff 510974.Apr 4 2023, 5:34 PM
tlongeri added reviewers: mehdi_amini, rdzhabarov.Apr 4 2023, 5:38 PM
tlongeri updated this revision to Diff 510977.Apr 4 2023, 5:43 PM

Missing direct dep

Harbormaster completed remote builds in B223712: Diff 510977.Apr 4 2023, 5:49 PM
tlongeri updated this revision to Diff 510982.Apr 4 2023, 5:59 PM

More missing direct dep

Harbormaster completed remote builds in B223714: Diff 510982.Apr 4 2023, 6:05 PM
dblaikie accepted this revision.Apr 4 2023, 6:05 PM
dblaikie added a subscriber: dblaikie.

Sounds good, thanks.

(you don't actually need to send these sort ofthings for presubmit review - you can use phab in draft mode (arc --draft, ifyou're using arc, I think) to get the presubmit checks run without sending for review, then submit directly - if the blaze build's already broken anyway, there's little haram in committing something to it that has some chance of fixing the issue... )

This revision is now accepted and ready to land.Apr 4 2023, 6:05 PM
Closed by commit rG71401f0f98f4: Fix bazel overlay after "[mlir] Introduce IRDL dialect" (authored by tlongeri, committed by dblaikie). · Explain WhyApr 4 2023, 6:09 PM
This revision was automatically updated to reflect the committed changes.
dblaikie added a commit: rG71401f0f98f4: Fix bazel overlay after "[mlir] Introduce IRDL dialect".
mehdi_amini added a comment.Apr 4 2023, 8:10 PM

+1 to everything David mentioned :)

GMNGeoffrey added a subscriber: GMNGeoffrey.EditedApr 5 2023, 1:42 PM
In D147583#4244871, @dblaikie wrote:

Sounds good, thanks.

(you don't actually need to send these sort ofthings for presubmit review - you can use phab in draft mode (arc --draft, ifyou're using arc, I think) to get the presubmit checks run without sending for review, then submit directly - if the blaze build's already broken anyway, there's little haram in committing something to it that has some chance of fixing the issue... )

David would you mind adding this to the README? I didn't know about draft mode and while I think we've discussed "no need to send trivial build fixes for review" in various places it doesn't appear to be documented

mehdi_amini added a comment.Apr 6 2023, 10:42 AM
In D147583#4246961, @GMNGeoffrey wrote:

David would you mind adding this to the README? I didn't know about draft mode and while I think we've discussed "no need to send trivial build fixes for review" in various places it doesn't appear to be documented

This is a general things in the LLVM repo, this is not specific to the Bazel overlay.

Herald added a subscriber: bviyer. · View Herald TranscriptApr 6 2023, 10:42 AM

Revision Contents

PathSize
utils/
bazel/
llvm-project-overlay/
mlir/
111 lines

Diff 510983

utils/bazel/llvm-project-overlay/mlir/BUILD.bazel

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 1,851 Lines • ▼ Show 20 Lines tbl_outs = [
), ),
], ],
tblgen = ":mlir-tblgen", tblgen = ":mlir-tblgen",
td_file = "include/mlir/Dialect/X86Vector/X86Vector.td", td_file = "include/mlir/Dialect/X86Vector/X86Vector.td",
deps = [":X86VectorTdFiles"], deps = [":X86VectorTdFiles"],
) )
##---------------------------------------------------------------------------## ##---------------------------------------------------------------------------##
# IRDL dialect.
##---------------------------------------------------------------------------##
td_library(
name = "IRDLTdFiles",
srcs = [
"include/mlir/Dialect/IRDL/IR/IRDL.td",
"include/mlir/Dialect/IRDL/IR/IRDLOps.td",
"include/mlir/Dialect/IRDL/IR/IRDLTypes.td",
],
includes = ["include"],
deps = [
":InferTypeOpInterfaceTdFiles",
":OpBaseTdFiles",
":SideEffectInterfacesTdFiles",
]
)
gentbl_cc_library(
name = "IRDLIncGen",
strip_include_prefix = "include",
tbl_outs = [
(
["-gen-dialect-decls"],
"include/mlir/Dialect/IRDL/IR/IRDLDialect.h.inc",
),
(
["-gen-dialect-defs"],
"include/mlir/Dialect/IRDL/IR/IRDLDialect.cpp.inc",
),
(
["-gen-op-decls"],
"include/mlir/Dialect/IRDL/IR/IRDL.h.inc",
),
(
["-gen-op-defs"],
"include/mlir/Dialect/IRDL/IR/IRDL.cpp.inc",
),
(
["-gen-typedef-decls"],
"include/mlir/Dialect/IRDL/IR/IRDLTypes.h.inc",
),
(
["-gen-typedef-defs"],
"include/mlir/Dialect/IRDL/IR/IRDLTypes.cpp.inc",
),
],
tblgen = ":mlir-tblgen",
td_file = "include/mlir/Dialect/IRDL/IR/IRDLOps.td",
deps = [":IRDLTdFiles"],
)
gentbl_cc_library(
name = "IRDLOpsIncGen",
strip_include_prefix = "include",
tbl_outs = [
(
["-gen-op-decls"],
"include/mlir/Dialect/IRDL/IR/IRDLOps.h.inc",
),
(
["-gen-op-defs"],
"include/mlir/Dialect/IRDL/IR/IRDLOps.cpp.inc",
),
],
tblgen = ":mlir-tblgen",
td_file = "include/mlir/Dialect/IRDL/IR/IRDLOps.td",
deps = [":IRDLTdFiles"],
)
gentbl_cc_library(
name = "IRDLTypesIncGen",
strip_include_prefix = "include",
tbl_outs = [
(
["-gen-typedef-decls"],
"include/mlir/Dialect/IRDL/IR/IRDLTypesGen.h.inc",
),
(
["-gen-typedef-defs"],
"include/mlir/Dialect/IRDL/IR/IRDLTypesGen.cpp.inc",
),
],
tblgen = ":mlir-tblgen",
td_file = "include/mlir/Dialect/IRDL/IR/IRDLTypes.td",
deps = [":IRDLTdFiles"],
)
cc_library(
name = "IRDLDialect",
srcs = ["lib/Dialect/IRDL/IR/IRDL.cpp"],
hdrs = [
"include/mlir/Dialect/IRDL/IR/IRDL.h",
"include/mlir/Dialect/IRDL/IR/IRDLTraits.h",
],
includes = ["include"],
deps = [
":Dialect",
":InferTypeOpInterface",
":IR",
":IRDLIncGen",
":IRDLOpsIncGen",
":IRDLTypesIncGen",
":Support",
"//llvm:Core",
"//llvm:Support",
],
)
##---------------------------------------------------------------------------##
# SCF dialect. # SCF dialect.
##---------------------------------------------------------------------------## ##---------------------------------------------------------------------------##
td_library( td_library(
name = "SCFTdFiles", name = "SCFTdFiles",
srcs = [ srcs = [
"include/mlir/Dialect/SCF/IR/DeviceMappingInterface.td", "include/mlir/Dialect/SCF/IR/DeviceMappingInterface.td",
"include/mlir/Dialect/SCF/IR/SCFOps.td", "include/mlir/Dialect/SCF/IR/SCFOps.td",
▲ Show 20 Lines • Show All 5,230 Lines • ▼ Show 20 Lines deps = [
":GPUToGPURuntimeTransforms", ":GPUToGPURuntimeTransforms",
":GPUToNVVMTransforms", ":GPUToNVVMTransforms",
":GPUToROCDLTransforms", ":GPUToROCDLTransforms",
":GPUToSPIRV", ":GPUToSPIRV",
":GPUToVulkanTransforms", ":GPUToVulkanTransforms",
":GPUTransformOps", ":GPUTransformOps",
":GPUTransforms", ":GPUTransforms",
":IR", ":IR",
":IRDLDialect",
":IndexDialect", ":IndexDialect",
":LLVMDialect", ":LLVMDialect",
":LLVMIRTransforms", ":LLVMIRTransforms",
":LLVMPassIncGen", ":LLVMPassIncGen",
":LinalgDialect", ":LinalgDialect",
":LinalgPassIncGen", ":LinalgPassIncGen",
":LinalgToLLVM", ":LinalgToLLVM",
":LinalgToStandard", ":LinalgToStandard",
▲ Show 20 Lines • Show All 3,728 Lines • Show Last 20 Lines