Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D147455

[DWARFLinker][NFC] Make interfaces to be compatible.
ClosedPublic
Actions

Authored by avl on Apr 3 2023, 10:12 AM.

Details

Reviewers
JDevlieghere
aprantl
clayborg
dblaikie
Commits
rG709bc112668d: [DWARFLinker][NFC] Make interfaces to be compatible.
Summary

This patch makes interface of AddressManager from DWARFLinker
to be compatible with AddressesMap from DWARFLinkerParallel.
This makes both linkers to be interchangeable.

Diff Detail

Event Timeline

avl created this revision.Apr 3 2023, 10:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 3 2023, 10:12 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
avl requested review of this revision.Apr 3 2023, 10:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 3 2023, 10:12 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B223389: Diff 510547.Apr 3 2023, 11:31 AM
avl added a child revision: D147952: [DWARFLinkerParallel] Add interface files, create a skeleton implementation..Apr 10 2023, 10:07 AM
avl added a comment.Apr 24 2023, 9:14 AM

friendly ping.

avl added a comment.May 1 2023, 12:17 PM

friendly ping.

JDevlieghere accepted this revision.May 1 2023, 1:57 PM

LGTM

This revision is now accepted and ready to land.May 1 2023, 1:57 PM
avl added a comment.May 2 2023, 6:31 AM

Thanks!

Closed by commit rG709bc112668d: [DWARFLinker][NFC] Make interfaces to be compatible. (authored by avl). · Explain WhyMay 2 2023, 6:37 AM
This revision was automatically updated to reflect the committed changes.
avl added a commit: rG709bc112668d: [DWARFLinker][NFC] Make interfaces to be compatible..

Revision Contents
Changeset List

PathSize
llvm/
include/
llvm/
DWARFLinker/
28 lines
lib/
DWARFLinker/
20 lines
tools/
dsymutil/
22 lines
45 lines
llvm-dwarfutil/
28 lines

Diff 518704

View Options

llvm/include/llvm/DWARFLinker/DWARFLinker.h

Loading...
View Options

llvm/lib/DWARFLinker/DWARFLinker.cpp

Loading...
View Options

llvm/tools/dsymutil/DwarfLinkerForBinary.h

Loading...
View Options

llvm/tools/dsymutil/DwarfLinkerForBinary.cpp

Loading...
View Options

llvm/tools/llvm-dwarfutil/DebugInfoLinker.cpp

Loading...