Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D146888

[clang-tidy] Flag std::forward on non-forwarding references
AbandonedPublic
Actions

Authored by ccotter on Mar 25 2023, 3:52 PM.

Details

Reviewers
njames93
Summary

Implement the std::forward specific enforcement of ES.56.

Diff Detail

Event Timeline

ccotter created this revision.Mar 25 2023, 3:52 PM
Herald added a reviewer: njames93. · View Herald TranscriptMar 25 2023, 3:52 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: PiotrZSL, carlosgalvezp, kbarton and 2 others. · View Herald Transcript
ccotter requested review of this revision.Mar 25 2023, 3:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2023, 3:52 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
PiotrZSL added a comment.EditedMar 25 2023, 4:03 PM

First, https://reviews.llvm.org/D144347 :)

Harbormaster completed remote builds in B221783: Diff 508349.Mar 25 2023, 4:32 PM
ccotter abandoned this revision.Mar 26 2023, 9:34 AM

Indeed - sorry i missed that

ccotter mentioned this in D144347: [clang-tidy] Add readability-forward-usage check.Mar 31 2023, 6:42 PM

Revision Contents
Changeset List

PathSize
clang-tools-extra/
clang-tidy/
cppcoreguidelines/
1 line
3 lines
32 lines
115 lines
docs/
5 lines
clang-tidy/
checks/
cppcoreguidelines/
35 lines
1 line
test/
clang-tidy/
checkers/
cppcoreguidelines/
163 lines

Diff 508349

View Options

clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt

Loading...
View Options

clang-tools-extra/clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp

Loading...
View Options

clang-tools-extra/clang-tidy/cppcoreguidelines/ForwardNonForwardingParameterCheck.h

Loading...
View Options

clang-tools-extra/clang-tidy/cppcoreguidelines/ForwardNonForwardingParameterCheck.cpp

Loading...
View Options

clang-tools-extra/docs/ReleaseNotes.rst

Loading...
View Options

clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/forward-non-forwarding-parameter.rst

Loading...
View Options

clang-tools-extra/docs/clang-tidy/checks/list.rst

Loading...
View Options

clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/forward-non-forwarding-parameter.cpp

Loading...