This is an archive of the discontinued LLVM Phabricator instance.

[clang][PowerPC] Remove remaining Darwin support
ClosedPublic

Authored by daltenty on Mar 20 2023, 3:03 PM.

Details

Summary

POWER Darwin support in the backend has been removed for some time: https://discourse.llvm.org/t/rfc-remove-darwin-support-from-power-backends
but Clang still has the TargetInfo and other remnants lying around.

This patch does some cleanup and removes those and other related frontend support still remaining. We adjust any tests using the triple to either remove
the test if unneeded or switch to another Power triple.

Diff Detail

Event Timeline

daltenty created this revision.Mar 20 2023, 3:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 20 2023, 3:03 PM
daltenty requested review of this revision.Mar 20 2023, 3:03 PM
daltenty added a reviewer: Restricted Project.
nemanjai accepted this revision.Mar 21 2023, 9:15 AM

This LGTM. Thanks for cleaning it up. Give it at least a week for any others that may have an opinion on this to chime in.

This revision is now accepted and ready to land.Mar 21 2023, 9:15 AM
MaskRay accepted this revision.Mar 21 2023, 5:38 PM
MaskRay added inline comments.
clang/lib/Sema/SemaAttr.cpp
225–226

delete ^//$

daltenty marked an inline comment as done.Mar 28 2023, 2:12 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2023, 2:14 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript