[Clang][OpenMP]Solved the the always truth condition in Arm64

[samuelmaina]

Summary

There was a bug in the getAArch64MTV function on the third if statement which returns truth as reported by this issue [[ https://github.com/llvm/llvm-project/issues/61319 |[Clang] Condition is always true which is caused by a possible copy-pasted bug in CGOpenMPRuntime.cpp
]].
All the testcases are passing. The first unit tests I could find are for functions that are 6 levels from this issue. The function is very low level and couldn't find a way to affect it from the higher functions.

[samuelmaina]

Updating D146370: [Clang][OpenMP]Solved the the always truth condition in Arm64

Reformatted the file
Reformatted the CGOpenMPRuntime.cpp to conform to clang standards

[efriedma]

The patch is currently impossible to read; please don't clang-format the whole file. There's a script clang-format-diff.py that can format just the parts of a file you change, if you need it.

As noted in the discussion on the bug report, needs a testcase.

[samuelmaina]

All the testcases are passing. The first unit tests I could find are for functions that are 6 levels higher from this function .The function is very low level and couldn't find a way to affect it from the higher functions.

[samtebbs]

Thank you Samuel. Since you don't have commit access, I can commit this for you if you'd like.

clang/lib/CodeGen/CGOpenMPRuntime.cpp

static bool getAArch64MTV(QualType QT, ParamKindTy Kind) {
   QT = QT.getCanonicalType();
 
   if (QT->isVoidType())
     return false;
 
   if (Kind == ParamKindTy::Uniform)
     return false;
 
-  if (Kind == ParamKindTy::LinearUVal || ParamKindTy::LinearRef)
+  if (Kind == ParamKindTy::LinearUVal || Kind == ParamKindTy::LinearRef)
     return false;
 
   if ((Kind == ParamKindTy::Linear || Kind == ParamKindTy::LinearVal) &&
       !QT->isReferenceType())
     return false;
 
   return true;
 }