This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Introduce SymbolFile::ParseAllLanguages
ClosedPublic

Authored by augusto2112 on Mar 16 2023, 4:25 PM.

Details

Summary

SymbolFile::ParseAllLanguages allows collecting the languages of the
extra compile units a SymbolFileDWARFDebugMap may have, which can't
be accessed otherwise. For every other symbol file type, it should
behave exactly the same as ParseLanguage.

rdar://97610458

Diff Detail

Event Timeline

augusto2112 created this revision.Mar 16 2023, 4:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 16 2023, 4:25 PM
augusto2112 requested review of this revision.Mar 16 2023, 4:25 PM
Herald added a project: Restricted Project. · View Herald Transcript
aprantl accepted this revision.Mar 17 2023, 3:45 PM

You could add a test similar to lldb/unittests/SymbolFile/DWARF/XcodeSDKModuleTests.cpp

lldb/include/lldb/Symbol/SymbolFile.h
154

I would increase the set size to 4. It's quite common to have C, C++, and ObjC in the same module.

This revision is now accepted and ready to land.Mar 17 2023, 3:45 PM
This revision was automatically updated to reflect the committed changes.