This is an archive of the discontinued LLVM Phabricator instance.

[RISCV][NFC] Add more tests for SLP vectorization (binops on load/store)
ClosedPublic

Authored by benshi001 on Mar 14 2023, 2:29 AM.

Diff Detail

Event Timeline

benshi001 created this revision.Mar 14 2023, 2:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 14 2023, 2:29 AM
benshi001 requested review of this revision.Mar 14 2023, 2:29 AM

It's not really clear to me what value the new tests are adding. At a minimum, this should probably be a different test file. The file you're modifying was intended to focus on the load/store vectorization - the add was only there to provide some use chain between the load and stores.

If you wanted to add some wider examples, that might be useful though.

reames requested changes to this revision.Mar 15 2023, 3:11 PM
This revision now requires changes to proceed.Mar 15 2023, 3:11 PM
reames retitled this revision from [RISCV][NFC] Add more tests for SLP vectorization to [RISCV][NFC] Add more tests for SLP vectorization (binops on load/store).Mar 15 2023, 3:12 PM

It's not really clear to me what value the new tests are adding. At a minimum, this should probably be a different test file. The file you're modifying was intended to focus on the load/store vectorization - the add was only there to provide some use chain between the load and stores.

If you wanted to add some wider examples, that might be useful though.

I have created a new file for my tests. Thanks!

reames accepted this revision.Mar 22 2023, 7:44 AM

LGTM

This revision is now accepted and ready to land.Mar 22 2023, 7:44 AM