This is an archive of the discontinued LLVM Phabricator instance.

Add a `skipRegion()` feature to the OpPrintingFlags for MLIR ASM printer
ClosedPublic

Authored by mehdi_amini on Mar 12 2023, 3:45 PM.

Details

Summary

This is a convenient flag for context where we intend to summarize a top-level
operation without the full-blown regions it may hold.

Diff Detail

Event Timeline

mehdi_amini created this revision.Mar 12 2023, 3:45 PM
mehdi_amini requested review of this revision.Mar 12 2023, 3:45 PM
rriddle accepted this revision.Mar 12 2023, 11:39 PM
rriddle added inline comments.
mlir/lib/IR/AsmPrinter.cpp
681

Why the comment, instead of something like ...?

This revision is now accepted and ready to land.Mar 12 2023, 11:39 PM
mehdi_amini added inline comments.Mar 13 2023, 5:54 AM
mlir/lib/IR/AsmPrinter.cpp
681

Felt more explicit, but I didn't consider ... before either...

Use ... instead of "/*skip region*/" comment