Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D145889

Add a `skipRegion()` feature to the OpPrintingFlags for MLIR ASM printer
ClosedPublic
Actions

Authored by mehdi_amini on Mar 12 2023, 3:45 PM.

Details

Reviewers
rriddle
Commits
rG5736a8a2dab4: Add a `skipRegion()` feature to the OpPrintingFlags for MLIR ASM printer
rG0fe16607a523: Add a `skipRegion()` feature to the OpPrintingFlags for MLIR ASM printer
Summary

This is a convenient flag for context where we intend to summarize a top-level
operation without the full-blown regions it may hold.

Diff Detail

Event Timeline

mehdi_amini created this revision.Mar 12 2023, 3:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 12 2023, 3:45 PM
Herald added subscribers: Moerafaat, zero9178, bzcheeseman and 19 others. · View Herald Transcript
mehdi_amini requested review of this revision.Mar 12 2023, 3:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 12 2023, 3:45 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B218912: Diff 504482.Mar 12 2023, 4:12 PM
rriddle accepted this revision.Mar 12 2023, 11:39 PM
rriddle added inline comments.
mlir/lib/IR/AsmPrinter.cpp
681

Why the comment, instead of something like ...?

This revision is now accepted and ready to land.Mar 12 2023, 11:39 PM
mehdi_amini added inline comments.Mar 13 2023, 5:54 AM
mlir/lib/IR/AsmPrinter.cpp
681

Felt more explicit, but I didn't consider ... before either...

mehdi_amini updated this revision to Diff 504629.Mar 13 2023, 6:40 AM

Use ... instead of "/*skip region*/" comment

Harbormaster completed remote builds in B219020: Diff 504629.Mar 13 2023, 8:21 AM
mehdi_amini added a child revision: D144814: Add capture of "IRUnits" as context for an MLIR Action.Mar 13 2023, 8:40 AM
Closed by commit rG0fe16607a523: Add a `skipRegion()` feature to the OpPrintingFlags for MLIR ASM printer (authored by mehdi_amini). · Explain WhyMar 13 2023, 8:51 AM
This revision was automatically updated to reflect the committed changes.
mehdi_amini added a commit: rG0fe16607a523: Add a `skipRegion()` feature to the OpPrintingFlags for MLIR ASM printer.
mehdi_amini added a reverting change: rGacab6a70fb40: Revert "Add a `skipRegion()` feature to the OpPrintingFlags for MLIR ASM….Mar 13 2023, 9:50 AM
mehdi_amini added a commit: rG5736a8a2dab4: Add a `skipRegion()` feature to the OpPrintingFlags for MLIR ASM printer.Mar 20 2023, 5:47 AM

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
IR/
9 lines
lib/
IR/
30 lines
Tools/
mlir-lsp-server/
19 lines
test/
mlir-lsp-server/
4 lines

Diff 504629

View Options

mlir/include/mlir/IR/OperationSupport.h

Loading...
View Options

mlir/lib/IR/AsmPrinter.cpp

Loading...
View Options

mlir/lib/Tools/mlir-lsp-server/MLIRServer.cpp

Loading...
View Options

mlir/test/mlir-lsp-server/hover.test

Loading...