This is an archive of the discontinued LLVM Phabricator instance.

[mlir][DialectUtils] Cleanup IndexingUtils and provide more affine variants while reusing implementations
ClosedPublic

Authored by nicolasvasilache on Mar 10 2023, 4:37 AM.

Diff Detail

Event Timeline

Herald added a reviewer: aartbik. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
nicolasvasilache requested review of this revision.Mar 10 2023, 4:37 AM
Herald added a project: Restricted Project. · View Herald Transcript
nicolasvasilache retitled this revision from [mlir][DialectUtils] Cleanup IndexingUtils and provide more affine variants while reusing imlpementatiions to [mlir][DialectUtils] Cleanup IndexingUtils and provide more affine variants while reusing implementations.

Commit message

ftynse accepted this revision.Mar 13 2023, 5:29 PM
ftynse added inline comments.
mlir/lib/Dialect/MemRef/Transforms/FoldMemRefAliasOps.cpp
57–58

Nit: can this be ArrayRef or at least a const reference?

120

Nit: can we drop the number of stack elements here?

This revision is now accepted and ready to land.Mar 13 2023, 5:29 PM
springerm accepted this revision.Mar 14 2023, 12:51 AM
springerm added inline comments.
mlir/lib/Dialect/MemRef/Transforms/FoldMemRefAliasOps.cpp
73

dot

qcolombet accepted this revision.Mar 14 2023, 1:17 AM
qcolombet added inline comments.
mlir/include/mlir/IR/AffineExpr.h
334

While we're here could we use ArrayRef instead of SmallVectorImpl?

348

Ditto

nicolasvasilache marked 5 inline comments as done.Mar 14 2023, 3:27 AM