Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D144959

[AMDGPU][AsmParser][NFC] Refine immediate operand definitions.
ClosedPublic
Actions

Authored by kosarev on Feb 28 2023, 5:28 AM.

Details

Reviewers
dp
arsenm
foad
rampitec
Commits
rG32f46ef09f88: [AMDGPU][AsmParser][NFC] Refine immediate operand definitions.

Diff Detail

Event Timeline

kosarev created this revision.Feb 28 2023, 5:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 28 2023, 5:28 AM
Herald added subscribers: StephenFan, kerbowa, hiraditya and 5 others. · View Herald Transcript
kosarev requested review of this revision.Feb 28 2023, 5:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 28 2023, 5:28 AM
Herald added subscribers: llvm-commits, wdng. · View Herald Transcript
kosarev updated this revision to Diff 501107.Feb 28 2023, 5:33 AM

Rework smrd_literal_offset as well.

Harbormaster completed remote builds in B216448: Diff 501107.Feb 28 2023, 6:24 AM
kosarev added a comment.Mar 23 2023, 4:04 AM

@dp Ping.

dp added inline comments.Mar 23 2023, 5:40 AM
llvm/lib/Target/AMDGPU/AMDGPUInstructions.td
137

This redefinition is unnecessary, 'let' would suffice.

llvm/lib/Target/AMDGPU/SMInstructions.td
723

Shouldn't this operand be optional?

kosarev added inline comments.Mar 29 2023, 9:28 AM
llvm/lib/Target/AMDGPU/AMDGPUInstructions.td
137

Can you elaborate? I'm not sure I understand the suggestion.

llvm/lib/Target/AMDGPU/SMInstructions.td
723

Nope, isSMRDLiteralOffset() doesn't accept zeroes.

dp added inline comments.Mar 29 2023, 9:38 AM
llvm/lib/Target/AMDGPU/AMDGPUInstructions.td
137

It looks like the code

AsmOperandClass ParserMatchClass = ImmOperandClass<name, optional>;

may be simplified as follows:

let ParserMatchClass = ImmOperandClass<name, optional>;
llvm/lib/Target/AMDGPU/SMInstructions.td
723

Oh I see, thanks.

kosarev updated this revision to Diff 509423.Mar 29 2023, 11:08 AM

The redefinition fixed.

dp accepted this revision.Mar 29 2023, 11:30 AM

LGTM

This revision is now accepted and ready to land.Mar 29 2023, 11:30 AM
Harbormaster completed remote builds in B222562: Diff 509423.Mar 29 2023, 1:41 PM
This revision was landed with ongoing or failed builds.Mar 30 2023, 7:16 AM
Closed by commit rG32f46ef09f88: [AMDGPU][AsmParser][NFC] Refine immediate operand definitions. (authored by kosarev). · Explain Why
This revision was automatically updated to reflect the committed changes.
kosarev added a commit: rG32f46ef09f88: [AMDGPU][AsmParser][NFC] Refine immediate operand definitions..

Revision Contents
Changeset List

PathSize
llvm/
lib/
Target/
AMDGPU/
31 lines
12 lines
12 lines

Diff 509665

View Options

llvm/lib/Target/AMDGPU/AMDGPUInstructions.td

Loading...
View Options

llvm/lib/Target/AMDGPU/SIInstrInfo.td

Loading...
View Options

llvm/lib/Target/AMDGPU/SMInstructions.td

Loading...