This is an archive of the discontinued LLVM Phabricator instance.

[llvm-debuginfo-analyzer] README
ClosedPublic

Authored by CarlosAlbertoEnciso on Feb 27 2023, 1:51 AM.

Details

Summary

LLVM debug information visual analyzer

For more information, see the RFC https://discourse.llvm.org/t/llvm-dev-rfc-llvm-dva-debug-information-visual-analyzer/62570

This patch:

Contains notes collected during the development, review and test.
It describes limitations, know issues and future work.

Diff Detail

Event Timeline

CarlosAlbertoEnciso requested review of this revision.Feb 27 2023, 1:51 AM
CarlosAlbertoEnciso added a comment.EditedFeb 27 2023, 2:06 AM

These are the next 2 patches:

//===----------------------------------------------------------------------===//
// Remove the use of macros in 'LVReader.h' that describe the bumpallocators.
//===----------------------------------------------------------------------===//
https://reviews.llvm.org/D137933#inline-1389904

Use a standard (or LLVM) map with typeinfo (would need a specialization
to expose equality and hasher) for the allocators and the creation
functions could be a function template.
//===----------------------------------------------------------------------===//
// Use a lit test instead of a unit test for the logical readers.
//===----------------------------------------------------------------------===//
https://reviews.llvm.org/D125783#inline-1324376

As the DebugInfoLogicalView library is sufficiently exposed via the
llvm-debuginfo-analyzer tool, follow the LLVM general approach and
use LIT tests to validate the logical readers.

Convert the unitests:
  llvm-project/llvm/unittests/DebugInfo/LogicalView/CodeViewReaderTest.cpp
  llvm-project/llvm/unittests/DebugInfo/LogicalView/ELFReaderTest.cpp

into LIT tests:
  llvm-project/llvm/test/DebugInfo/LogicalView/CodeViewReader.test
  llvm-project/llvm/test/DebugInfo/LogicalView/ELFReader.test
Orlando accepted this revision.Mar 15 2023, 5:13 AM

LGTM

llvm/tools/llvm-debuginfo-analyzer/README.txt
150

findd -> find?

This revision is now accepted and ready to land.Mar 15 2023, 5:13 AM
llvm/tools/llvm-debuginfo-analyzer/README.txt
150

It should be find.

This revision was landed with ongoing or failed builds.Mar 15 2023, 6:34 AM
This revision was automatically updated to reflect the committed changes.

@Orlando Thanks very much for your review.