This is an archive of the discontinued LLVM Phabricator instance.

Differential D144798

[DebugInfo] Remove `dbg.addr` from llvm-reduce
ClosedPublic

Authored by jryans on Feb 25 2023, 4:13 PM.

Details

Reviewers
Orlando
StephenTozer
probinson
rnk
Commits
rG065e77b1b7f3: [DebugInfo] Remove `dbg.addr` from llvm-reduce
Summary

Part of dbg.addr removal
Discussed in https://discourse.llvm.org/t/what-is-the-status-of-dbg-addr/62898

Depends on D144797

Diff Detail

Unit TestsFailed

TimeTest
150 msx64 debian > LLVM.DebugInfo/X86::dbg-addr-dse.ll
150 msx64 debian > LLVM.DebugInfo/X86::dbg-addr.ll
60,040 msx64 debian > MLIR.Examples/standalone::test.toy
130 msx64 debian > MLIR.Target/LLVMIR::llvmir-debug.mlir
110 msx64 debian > MLIR.Target/LLVMIR/Import::debug-info.ll

Event Timeline

jryans created this revision.Feb 25 2023, 4:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 25 2023, 4:13 PM
jryans requested review of this revision.Feb 25 2023, 4:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 25 2023, 4:13 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
jryans added a child revision: D144799: [DebugInfo] Remove `dbg.addr` from Analysis.Feb 25 2023, 4:13 PM
jryans retitled this revision from [DebugInfo] Remove `dbg.addr` from llvm-reduce r=Orlando,StephenTozer,probinson,rnk to [DebugInfo] Remove `dbg.addr` from llvm-reduce.Feb 25 2023, 4:17 PM
jryans added a project: debug-info.
Harbormaster completed remote builds in B215967: Diff 500465.Feb 25 2023, 5:21 PM
StephenTozer accepted this revision.Feb 27 2023, 2:28 AM
This revision is now accepted and ready to land.Feb 27 2023, 2:28 AM
This revision was landed with ongoing or failed builds.Mar 2 2023, 1:31 AM
Closed by commit rG065e77b1b7f3: [DebugInfo] Remove `dbg.addr` from llvm-reduce (authored by jryans). · Explain Why
This revision was automatically updated to reflect the committed changes.
jryans added a commit: rG065e77b1b7f3: [DebugInfo] Remove `dbg.addr` from llvm-reduce.

Revision Contents

PathSize
llvm/
test/
tools/
llvm-reduce/
3 lines

Diff 500465

llvm/test/tools/llvm-reduce/remove-args-dbg-intrinsics.ll

; llvm-reduce shouldn't remove arguments of debug intrinsics, because the resulting module will be ill-formed. ; llvm-reduce shouldn't remove arguments of debug intrinsics, because the resulting module will be ill-formed.
; ;
; RUN: llvm-reduce --abort-on-invalid-reduction --delta-passes=arguments --test FileCheck --test-arg --check-prefixes=CHECK-INTERESTINGNESS --test-arg %s --test-arg --input-file %s --output %t ; RUN: llvm-reduce --abort-on-invalid-reduction --delta-passes=arguments --test FileCheck --test-arg --check-prefixes=CHECK-INTERESTINGNESS --test-arg %s --test-arg --input-file %s --output %t
; RUN: FileCheck --check-prefix=CHECK-FINAL %s < %t ; RUN: FileCheck --check-prefix=CHECK-FINAL %s < %t
; CHECK-INTERESTINGNESS: declare void @llvm.dbg.addr
; CHECK-FINAL: declare void @llvm.dbg.addr(metadata, metadata, metadata)
declare void @llvm.dbg.addr(metadata, metadata, metadata)
; CHECK-INTERESTINGNESS: declare void @llvm.dbg.declare ; CHECK-INTERESTINGNESS: declare void @llvm.dbg.declare
; CHECK-FINAL: declare void @llvm.dbg.declare(metadata, metadata, metadata) ; CHECK-FINAL: declare void @llvm.dbg.declare(metadata, metadata, metadata)
declare void @llvm.dbg.declare(metadata, metadata, metadata) declare void @llvm.dbg.declare(metadata, metadata, metadata)
; CHECK-INTERESTINGNESS: declare void @llvm.dbg.value ; CHECK-INTERESTINGNESS: declare void @llvm.dbg.value
; CHECK-FINAL: declare void @llvm.dbg.value(metadata, metadata, metadata) ; CHECK-FINAL: declare void @llvm.dbg.value(metadata, metadata, metadata)
declare void @llvm.dbg.value(metadata, metadata, metadata) declare void @llvm.dbg.value(metadata, metadata, metadata)