This is an archive of the discontinued LLVM Phabricator instance.

[SVE] Add intrinsics for uniform dsp operations that explicitly undefine the result for inactive lanes.
ClosedPublic

Authored by dewen on Feb 24 2023, 12:09 AM.

Details

Summary

This patch adds new intrinsics for uniform dsp operations and changes the lowering for the following builtins to emit calls to the new aarch64.sve.###.u intrinsics.

svsqsub_x
svsqsub_n_x
svuqsub_x
svuqsub_n_x
svsqsubr_x
svsqsubr_n_x
svuqsubr_x
svuqsubr_n_x

Diff Detail

Event Timeline

dewen created this revision.Feb 24 2023, 12:09 AM
Herald added a project: Restricted Project. · View Herald Transcript
dewen requested review of this revision.Feb 24 2023, 12:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 24 2023, 12:09 AM
paulwalker-arm accepted this revision.Feb 24 2023, 9:11 AM

One minor suggestion but otherwise looks good.

llvm/test/CodeGen/AArch64/sve2-intrinsics-uniform-dsp-undef.ll
14

Please align the function parameters when landing the patch.

This revision is now accepted and ready to land.Feb 24 2023, 9:11 AM
dewen added a comment.Feb 24 2023, 5:27 PM

One minor suggestion but otherwise looks good.

Okay, thank you for your review. I'll align the patch.

dewen updated this revision to Diff 500409.Feb 25 2023, 3:54 AM
This revision was landed with ongoing or failed builds.Feb 27 2023, 2:45 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 27 2023, 2:45 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript