This is an archive of the discontinued LLVM Phabricator instance.

[mlir][vector] Improve vector type accessor methods
ClosedPublic

Authored by antiagainst on Feb 15 2023, 7:05 PM.

Details

Summary

Plain getVectorType() can be quite confusing and error-prone
given that, well, vector ops always work on vector types, and
it can commonly involve both source and result vectors. So this
commit makes various such accessor methods to be explicit w.r.t.
source or result vectors.

Diff Detail

Event Timeline

antiagainst created this revision.Feb 15 2023, 7:05 PM
Herald added a reviewer: ftynse. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
antiagainst requested review of this revision.Feb 15 2023, 7:05 PM
ThomasRaoux accepted this revision.Feb 15 2023, 7:21 PM

Thanks!

This revision is now accepted and ready to land.Feb 15 2023, 7:21 PM

please mark it as NFC

please mark it as NFC

Done

This revision was landed with ongoing or failed builds.Feb 15 2023, 8:11 PM
This revision was automatically updated to reflect the committed changes.