This is an archive of the discontinued LLVM Phabricator instance.

[SVE][Builtins] Lower X forms of fp binop/mla arithmetic builtins to dedicated intrinsics
ClosedPublic

Authored by paulwalker-arm on Feb 10 2023, 10:19 AM.

Details

Summary

This patch changes the lowering for the following fp builtins to
emit calls to the new aarch64.sve.###.u intrinsics.

svabd_x, svabd_n_x
svadd_x, svadd_n_x
svdiv_x, svdiv_n_x
svdivr_x, svdivr_n_x
svmad_x, svmad_n_x
svmax_x, svmax_n_x
svmaxnm_x, svmaxnm_n_x
svmin_x, svmin_n_x
svminnm_x, svminnm_n_x
svmla_x, svmla_n_x
svmls_x, svmls_n_x
svmsb_x, svmsb_n_x
svmul_x, svmul_n_x
svmulx_x, svmulx_n_x
svnmad_x, svnmad_n_x
svnmla_x, svnmla_n_x
svnmls_x, svnmls_n_x
svnmsb_X, svnmsb_n_x
svsub_x, svsub_n_x
svsubr_x, svsubr_n_x

Depends on D143765.

Diff Detail

Event Timeline

paulwalker-arm requested review of this revision.Feb 10 2023, 10:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 10 2023, 10:19 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Remove bogus comment.

Matt added a subscriber: Matt.Feb 10 2023, 9:45 PM
paulwalker-arm planned changes to this revision.Feb 13 2023, 7:30 AM

Fixed incorrect operand ordering for reversed accumulator builtins.

sdesmalen accepted this revision.Feb 14 2023, 12:56 AM
This revision is now accepted and ready to land.Feb 14 2023, 12:56 AM
dewen added a subscriber: dewen.Feb 19 2023, 10:56 PM

Hi, thank you. When will this patch be pushed to the master?@paulwalker-arm

Hi, thank you. When will this patch be pushed to the master?@paulwalker-arm

I expect to push the patch to main in the next day or so. I just need to look over some recent InstCombine work, which I think will need to be updated due to this patch.

This revision was landed with ongoing or failed builds.Mar 12 2023, 5:16 AM
This revision was automatically updated to reflect the committed changes.