[MLIR][Presburger] Matrix: hide expensive consistency check behind EXPENSIVE_CHECKS macro

[arjunp]

Summary

This significantly improves performance of Release assert builds.

[bondhugula]

mlir/lib/Analysis/Presburger/Matrix.cpp

370

I don't see a single use of this macro in the MLIR codebase or the LLVM C++ sources anywhere. I'm not sure if this is the right one to use. @mehdi_amini, @rriddle - do you have a suggestion?

[bondhugula]

mlir/lib/Analysis/Presburger/Matrix.cpp

370

For context, hasConsistentState is only used inside of assert(...) and is meant only for that.

[arjunp]

Happy to move it to a different function or just add a function parameter
(off by default) if preferred.

[rkayaith]

mlir/lib/Analysis/Presburger/Matrix.cpp

370

The right macro seems to be just EXPENSIVE_CHECKS, e.g.
https://github.com/llvm/llvm-project/blob/dac423bd571858a85f3b388904392f0e55421d7d/mlir/lib/Pass/Pass.cpp#L493

https://github.com/llvm/llvm-project/blob/dac423bd571858a85f3b388904392f0e55421d7d/llvm/include/llvm/ADT/STLExtras.h#L1648

[arjunp]

Use correct macro

[arjunp]

mlir/lib/Analysis/Presburger/Matrix.cpp

370

My bad. I picked it up from the CMake, should've checked what the actual macro is. Fixed now.

[bondhugula]

LGTM - thanks

[arjunp]

Rebase to try and fix windows build

mlir/lib/Analysis/Presburger/Matrix.cpp

 
 void Matrix::dump() const { print(llvm::errs()); }
 
 bool Matrix::hasConsistentState() const {
   if (data.size() != nRows * nReservedColumns)
     return false;
   if (nColumns > nReservedColumns)
     return false;
+#ifdef EXPENSIVE_CHECKS
   for (unsigned r = 0; r < nRows; ++r)
     for (unsigned c = nColumns; c < nReservedColumns; ++c)
       if (data[r * nReservedColumns + c] != 0)
         return false;
+#endif
   return true;
 }