Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
LGTM, my first impression is why so many diff, however I found it's because this patch also add llc -mtriple=riscv32/llc -mtriple=riscv64 without -mattr, and then...the diff algorithm result so many diff.
Comment Actions
Thanks for the review, @kito-cheng. Note that I do not have commit access so I cannot commit this myself.
Comment Actions
Do you mind provide your email address, so that I can put right author info in commit log?
Comment Actions
The other way of handling this would be to add additional run lines focused on the -target-abi flags and check the stackalign attribute in that output....but that doesn't seem necessarily better, and we get the same coverage due to the ABI inference logic that's implemented. So LGTM.