Page MenuHomePhabricator

[Driver] Add -mllvm= as an alias for -mllvm
ClosedPublic

Authored by MaskRay on Feb 4 2023, 12:58 PM.

Details

Summary

Similar to D131455 (-Xclang=). As well as making it convenient for some build
systems, this allows -Xarch_device '-mllvm=--inline-threshold=100' (and
-Xarch_host; so we don't need to allow space separators which are uncommon in
driver code).

Bear in mind that -mllvm options are unstable and should be avoided if possible.

Diff Detail

Unit TestsFailed

TimeTest
50 msx64 debian > Flang.Driver::driver-help-hidden.f90
Script: -- : 'RUN: at line 5'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/flang-new --help-hidden 2>&1 | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/flang/test/Driver/driver-help-hidden.f90
70 msx64 debian > Flang.Driver::driver-help.f90
Script: -- : 'RUN: at line 5'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/flang-new -help 2>&1 | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/flang/test/Driver/driver-help.f90 --check-prefix=HELP

Event Timeline

MaskRay created this revision.Feb 4 2023, 12:58 PM
Herald added a project: Restricted Project. · View Herald Transcript
MaskRay requested review of this revision.Feb 4 2023, 12:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2023, 12:58 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
MaskRay updated this revision to Diff 494844.Feb 4 2023, 1:03 PM

fix test

jhuber6 accepted this revision.Feb 4 2023, 1:22 PM

This looks good. I've had similar problems when trying to pass things with arguments via the -Xarch or -Xopenmp-target= options.

This revision is now accepted and ready to land.Feb 4 2023, 1:22 PM
yaxunl accepted this revision.Feb 5 2023, 6:06 AM

LGTM. Thanks.

This revision was landed with ongoing or failed builds.Feb 5 2023, 10:30 AM
This revision was automatically updated to reflect the committed changes.