This is an archive of the discontinued LLVM Phabricator instance.

[InstCombine][NFC] Add tests pre-implementation of issue #54856
ClosedPublic

Authored by jmciver on Jan 31 2023, 9:11 PM.

Details

Summary

Provide both positive and negative testing using scalar and vector values for
issue #54856.

Diff Detail

Event Timeline

jmciver created this revision.Jan 31 2023, 9:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2023, 9:11 PM
Herald added a subscriber: StephenFan. · View Herald Transcript
jmciver published this revision for review.Feb 1 2023, 3:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2023, 3:10 PM
jmciver updated this revision to Diff 494097.Feb 1 2023, 3:57 PM

Fix vector of two elements test case

RKSimon added inline comments.Feb 16 2023, 6:52 AM
llvm/test/Transforms/InstCombine/icmp-logical.ll
1775 ↗(On Diff #494097)

Sequentially numbering test names for a fold isn't great - it'd be better to use the name to describe the specific pattern in more detail

jmciver updated this revision to Diff 499008.Feb 20 2023, 6:41 PM

Remove sequential test names in favor of pattern details

jmciver added inline comments.Feb 20 2023, 6:45 PM
llvm/test/Transforms/InstCombine/icmp-logical.ll
1775 ↗(On Diff #494097)

Thanks for the input! I have attempted to improve the test names with pattern details.

jmciver marked an inline comment as done.Feb 21 2023, 3:01 PM
jmciver updated this revision to Diff 508456.Mar 26 2023, 7:01 PM

Rebase to latest main.

jmciver updated this revision to Diff 508469.Mar 26 2023, 8:47 PM

Rebase to latest main.

jmciver updated this revision to Diff 508480.Mar 26 2023, 10:18 PM

Rebase onto latest main.

jmciver updated this revision to Diff 522024.May 14 2023, 2:28 PM

Add undef based splat vector tests

jmciver updated this revision to Diff 523250.May 17 2023, 8:45 PM

Add postfix of "fail" to the names of tests that intentionally do not change

jmciver updated this revision to Diff 523251.May 17 2023, 8:47 PM

Add postfix of "fail" to the names of tests that intentionally do not change

jmciver updated this revision to Diff 523888.May 19 2023, 12:12 PM

Move tests from icmp-logical.ll to icmp-power2-and-icmp-shifted-mask.ll

goldstein.w.n accepted this revision.Jun 1 2023, 9:20 PM
goldstein.w.n added a subscriber: goldstein.w.n.

LGTM.

Probably slightly more tests than needed but more is always better than less :)

This revision is now accepted and ready to land.Jun 1 2023, 9:20 PM

@goldstein.w.n thanks for taking the time to review.