Page MenuHomePhabricator

jmciver (John McIver)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 9 2022, 9:22 PM (17 w, 1 d)

Recent Activity

Mon, Jul 25

jmciver added a comment to D125717: [InstCombine] Optimize and of icmps with power-of-2 and contiguous masks.

Thanks @RKSimon! I will work on adding the additional tests.

Mon, Jul 25, 3:34 PM · Restricted Project, Restricted Project

Tue, Jul 12

jmciver added a comment to D129541: [llvm][IPO] Add IR function attribute fine_grained_bitfields.

@nikic thanks for the feedback.

Tue, Jul 12, 10:07 PM · Restricted Project, Restricted Project
jmciver edited reviewers for D129542: [CodeGen] Add codegen of IR function attribute fine_grained_bitfields, added: efriedma; removed: eli.friedman.
Tue, Jul 12, 9:20 PM · Restricted Project, Restricted Project
jmciver added reviewers for D129542: [CodeGen] Add codegen of IR function attribute fine_grained_bitfields: eli.friedman, rjmccall, aaron.ballman.
Tue, Jul 12, 10:49 AM · Restricted Project, Restricted Project
jmciver published D129542: [CodeGen] Add codegen of IR function attribute fine_grained_bitfields for review.
Tue, Jul 12, 10:34 AM · Restricted Project, Restricted Project
jmciver added reviewers for D129541: [llvm][IPO] Add IR function attribute fine_grained_bitfields: eli.friedman, rjmccall, davidxl.
Tue, Jul 12, 10:33 AM · Restricted Project, Restricted Project
jmciver published D129541: [llvm][IPO] Add IR function attribute fine_grained_bitfields for review.
Tue, Jul 12, 10:18 AM · Restricted Project, Restricted Project

Jun 24 2022

jmciver published D128501: [CodeGen] Make uninitialized Lvalue bit-field stores poison compatible for review.
Jun 24 2022, 1:43 AM · Restricted Project, Restricted Project

Jun 23 2022

jmciver added a comment to D125717: [InstCombine] Optimize and of icmps with power-of-2 and contiguous masks.

To reduce performance impact I am thinking that the call to foldLogOpOfMaskedICmps_AllZeros_BMask_NotMixed_and_NotAllOnes should be moved into a new function, foldPowerOf2AndWithLesserContinuous, and then call this function from foldAndOrOfICmps. This will help to keep the purpose of foldLogOpOfMaskedICmps clear and reduce the overhead by not testing for a less probable optimization early.

Jun 23 2022, 8:50 PM · Restricted Project, Restricted Project

Jun 8 2022

jmciver closed D127271: [pseudo] Fix link time undefined reference to llvm::EnableABIBreakingChecks.

Obsoleted by D127269.

Jun 8 2022, 8:36 PM · Restricted Project, Restricted Project
jmciver added a comment to D127271: [pseudo] Fix link time undefined reference to llvm::EnableABIBreakingChecks.

Thanks @sammccall for taking the time to review!

Jun 8 2022, 3:08 PM · Restricted Project, Restricted Project
jmciver added a comment to D127271: [pseudo] Fix link time undefined reference to llvm::EnableABIBreakingChecks.

This patch is associated to: https://github.com/llvm/llvm-project/issues/55935

Jun 8 2022, 2:45 PM · Restricted Project, Restricted Project
jmciver added reviewers for D127271: [pseudo] Fix link time undefined reference to llvm::EnableABIBreakingChecks: hokein, sammccall.
Jun 8 2022, 2:41 PM · Restricted Project, Restricted Project

Jun 7 2022

jmciver published D127271: [pseudo] Fix link time undefined reference to llvm::EnableABIBreakingChecks for review.
Jun 7 2022, 11:56 PM · Restricted Project, Restricted Project

May 17 2022

jmciver added reviewers for D125717: [InstCombine] Optimize and of icmps with power-of-2 and contiguous masks: RKSimon, fhahn, spatel, yamauchi, nikic.
May 17 2022, 12:08 AM · Restricted Project, Restricted Project
jmciver published D125717: [InstCombine] Optimize and of icmps with power-of-2 and contiguous masks for review.
May 17 2022, 12:00 AM · Restricted Project, Restricted Project

Apr 17 2022

jmciver added a comment to D123798: [llvm-objcopy] Make llvm-strip --only-keep-debug suppress default --strip-all.

@MaskRay Thank you for your feedback! I have implemented the following changes:

Apr 17 2022, 8:28 PM · Restricted Project, Restricted Project
jmciver retitled D123798: [llvm-objcopy] Make llvm-strip --only-keep-debug suppress default --strip-all from [llvm-objcopy] llvm-strip option --only-keep-debug should suppress default --strip-all to [llvm-objcopy] Make llvm-strip --only-keep-debug suppress default --strip-all.
Apr 17 2022, 8:05 PM · Restricted Project, Restricted Project
jmciver updated the diff for D123798: [llvm-objcopy] Make llvm-strip --only-keep-debug suppress default --strip-all.

[llvm-objcopy] llvm-strip option --only-keep-debug should suppress default --strip-all

Apr 17 2022, 8:03 PM · Restricted Project, Restricted Project
jmciver updated the diff for D123798: [llvm-objcopy] Make llvm-strip --only-keep-debug suppress default --strip-all.

[llvm-objcopy] llvm-strip option --only-keep-debug should suppress default --strip-all

Apr 17 2022, 7:58 PM · Restricted Project, Restricted Project
jmciver updated the diff for D123798: [llvm-objcopy] Make llvm-strip --only-keep-debug suppress default --strip-all.

Updating D123798: [llvm-objcopy] llvm-strip option --only-keep-debug should suppress default --strip-all

Apr 17 2022, 7:54 PM · Restricted Project, Restricted Project

Apr 16 2022

jmciver added reviewers for D123798: [llvm-objcopy] Make llvm-strip --only-keep-debug suppress default --strip-all: mstorsjo, MaskRay, rmaz.
Apr 16 2022, 12:57 PM · Restricted Project, Restricted Project

Apr 14 2022

jmciver added a comment to D123798: [llvm-objcopy] Make llvm-strip --only-keep-debug suppress default --strip-all.

Patch is ready for review.

Apr 14 2022, 7:36 PM · Restricted Project, Restricted Project
jmciver published D123798: [llvm-objcopy] Make llvm-strip --only-keep-debug suppress default --strip-all for review.
Apr 14 2022, 12:27 PM · Restricted Project, Restricted Project
jmciver abandoned D123738: [llvm-objcopy] option --only-keep-debug should suppress default --strip-all.
Apr 14 2022, 8:17 AM · Restricted Project, Restricted Project

Apr 13 2022

jmciver updated the diff for D123738: [llvm-objcopy] option --only-keep-debug should suppress default --strip-all.

Updating D123738: [llvm-objcopy] option --only-keep-debug should suppress default --strip-all

Apr 13 2022, 11:24 PM · Restricted Project, Restricted Project
jmciver updated the summary of D123738: [llvm-objcopy] option --only-keep-debug should suppress default --strip-all.
Apr 13 2022, 3:16 PM · Restricted Project, Restricted Project
jmciver updated the summary of D123738: [llvm-objcopy] option --only-keep-debug should suppress default --strip-all.
Apr 13 2022, 3:03 PM · Restricted Project, Restricted Project
jmciver requested review of D123738: [llvm-objcopy] option --only-keep-debug should suppress default --strip-all.
Apr 13 2022, 2:50 PM · Restricted Project, Restricted Project