This is an archive of the discontinued LLVM Phabricator instance.

Differential D143031

[InstCombine][NFC] Add tests with icmp splat vectors and B masks
ClosedPublic

Authored by jmciver on Jan 31 2023, 4:32 PM.

Details

Reviewers
RKSimon
fhahn
spatel
hjyamauchi
nikic
Commits
rG353720a95b5d: [InstCombine][NFC] Add tests with icmp splat vectors and B masks
Summary

Add tests to verifying future support for splat vectors containing poison/undef
in llvm::decomposeBitTestICmp.

Diff Detail

Event Timeline

jmciver created this revision.Jan 31 2023, 4:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2023, 4:32 PM
Herald added a subscriber: StephenFan. · View Herald Transcript
jmciver added a child revision: D143032: [InstCombine] Allow splats with poison/undef in llvm::decomposeBitTestICmp.Jan 31 2023, 4:40 PM
Harbormaster completed remote builds in B211101: Diff 493775.Jan 31 2023, 6:10 PM
jmciver updated this revision to Diff 494028.Feb 1 2023, 12:04 PM

Fix label naming error

jmciver mentioned this in D143032: [InstCombine] Allow splats with poison/undef in llvm::decomposeBitTestICmp.Feb 1 2023, 12:06 PM
jmciver updated this revision to Diff 494068.Feb 1 2023, 1:56 PM

Convert splat vectors from undef to poison

Harbormaster completed remote builds in B211285: Diff 494028.Feb 1 2023, 1:59 PM
jmciver published this revision for review.Feb 1 2023, 3:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2023, 3:10 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B211309: Diff 494068.Feb 1 2023, 3:25 PM
jmciver updated this revision to Diff 508462.Mar 26 2023, 7:57 PM

Rebase onto latest main.

Harbormaster completed remote builds in B221869: Diff 508462.Mar 26 2023, 8:40 PM
RKSimon accepted this revision.Apr 5 2023, 3:40 AM

LGTM

This revision is now accepted and ready to land.Apr 5 2023, 3:40 AM
jmciver added a comment.Apr 7 2023, 11:16 AM

@RKSimon thanks for taking the time to review the patch!

I have recently requested repository access. In the interim can you please land this patch for me?

Name: John McIver
Email: john.mciver.iii@gmail.com

Closed by commit rG353720a95b5d: [InstCombine][NFC] Add tests with icmp splat vectors and B masks (authored by jmciver, committed by RKSimon). · Explain WhyApr 11 2023, 1:00 AM
This revision was automatically updated to reflect the committed changes.
RKSimon added a commit: rG353720a95b5d: [InstCombine][NFC] Add tests with icmp splat vectors and B masks.

Revision Contents

PathSize
llvm/
test/
Transforms/
InstCombine/
30 lines

Diff 512356

llvm/test/Transforms/InstCombine/icmp-logical.ll

Show First 20 Lines • Show All 371 Lines • ▼ Show 20 Lines
; ;
%t1 = and i32 %x, 2147483647 %t1 = and i32 %x, 2147483647
%t2 = icmp ne i32 %t1, 0 %t2 = icmp ne i32 %t1, 0
%t3 = icmp ne i32 %x, 2147483647 %t3 = icmp ne i32 %x, 2147483647
%t4 = select i1 %t3, i1 true, i1 %t2 %t4 = select i1 %t3, i1 true, i1 %t2
ret i1 %t4 ret i1 %t4
} }
define <2 x i1> @nomask_splat_and_B_allones(<2 x i32> %A) {
; CHECK-LABEL: @nomask_splat_and_B_allones(
; CHECK-NEXT: [[TST1:%.*]] = icmp slt <2 x i32> [[A:%.*]], <i32 0, i32 poison>
; CHECK-NEXT: [[MASK2:%.*]] = and <2 x i32> [[A]], <i32 1879048192, i32 1879048192>
; CHECK-NEXT: [[TST2:%.*]] = icmp eq <2 x i32> [[MASK2]], <i32 1879048192, i32 1879048192>
; CHECK-NEXT: [[RES:%.*]] = and <2 x i1> [[TST1]], [[TST2]]
; CHECK-NEXT: ret <2 x i1> [[RES]]
;
%tst1 = icmp slt <2 x i32> %A, <i32 0, i32 poison>
%mask2 = and <2 x i32> %A, <i32 1879048192, i32 1879048192>
%tst2 = icmp eq <2 x i32> %mask2, <i32 1879048192, i32 1879048192>
%res = and <2 x i1> %tst1, %tst2
ret <2 x i1> %res
}
define <2 x i1> @nomask_splat_and_B_mixed(<2 x i32> %A) {
; CHECK-LABEL: @nomask_splat_and_B_mixed(
; CHECK-NEXT: [[TST1:%.*]] = icmp sgt <2 x i32> [[A:%.*]], <i32 -1, i32 poison>
; CHECK-NEXT: [[MASK2:%.*]] = and <2 x i32> [[A]], <i32 1879048192, i32 1879048192>
; CHECK-NEXT: [[TST2:%.*]] = icmp eq <2 x i32> [[MASK2]], <i32 1879048192, i32 1879048192>
; CHECK-NEXT: [[RES:%.*]] = and <2 x i1> [[TST1]], [[TST2]]
; CHECK-NEXT: ret <2 x i1> [[RES]]
;
%tst1 = icmp sgt <2 x i32> %A, <i32 -1, i32 poison>
%mask2 = and <2 x i32> %A, <i32 1879048192, i32 1879048192>
%tst2 = icmp eq <2 x i32> %mask2, <i32 1879048192, i32 1879048192>
%res = and <2 x i1> %tst1, %tst2
ret <2 x i1> %res
}
; PR32401 - https://bugs.llvm.org/show_bug.cgi?id=32401 ; PR32401 - https://bugs.llvm.org/show_bug.cgi?id=32401
define i1 @cmpeq_bitwise(i8 %a, i8 %b, i8 %c, i8 %d) { define i1 @cmpeq_bitwise(i8 %a, i8 %b, i8 %c, i8 %d) {
; CHECK-LABEL: @cmpeq_bitwise( ; CHECK-LABEL: @cmpeq_bitwise(
; CHECK-NEXT: [[TMP1:%.*]] = icmp eq i8 [[A:%.*]], [[B:%.*]] ; CHECK-NEXT: [[TMP1:%.*]] = icmp eq i8 [[A:%.*]], [[B:%.*]]
; CHECK-NEXT: [[TMP2:%.*]] = icmp eq i8 [[C:%.*]], [[D:%.*]] ; CHECK-NEXT: [[TMP2:%.*]] = icmp eq i8 [[C:%.*]], [[D:%.*]]
; CHECK-NEXT: [[CMP:%.*]] = and i1 [[TMP1]], [[TMP2]] ; CHECK-NEXT: [[CMP:%.*]] = and i1 [[TMP1]], [[TMP2]]
; CHECK-NEXT: ret i1 [[CMP]] ; CHECK-NEXT: ret i1 [[CMP]]
▲ Show 20 Lines • Show All 1,498 Lines • Show Last 20 Lines