Provide both positive and negative testing using scalar and vector values for
issue #54856.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Time | Test | |
---|---|---|
60,050 ms | x64 debian > MLIR.Examples/standalone::test.toy |
Event Timeline
llvm/test/Transforms/InstCombine/icmp-logical.ll | ||
---|---|---|
1775 | Sequentially numbering test names for a fold isn't great - it'd be better to use the name to describe the specific pattern in more detail |
llvm/test/Transforms/InstCombine/icmp-logical.ll | ||
---|---|---|
1775 | Thanks for the input! I have attempted to improve the test names with pattern details. |
Comment Actions
LGTM.
Probably slightly more tests than needed but more is always better than less :)
Sequentially numbering test names for a fold isn't great - it'd be better to use the name to describe the specific pattern in more detail