This is an archive of the discontinued LLVM Phabricator instance.

[mlir][Linalg] Put a proper type on transform.structured.match op
ClosedPublic

Authored by nicolasvasilache on Jan 26 2023, 8:49 AM.

Details

Summary

This allows much better verification messages in consuming ops that properly declare
TransformHandleTypeInterface on their operands.

Downstream tests can be updated with a command resembling:

git grep -l "structured\.match" mlir/test | xargs -i sed -i {} -e  "s/\(structured.match.*\)/\1 : (\!pdl.operation) -> \!pdl.operation/g"

Diff Detail

Event Timeline

nicolasvasilache requested review of this revision.Jan 26 2023, 8:49 AM
ftynse accepted this revision.Jan 26 2023, 8:51 AM
This revision is now accepted and ready to land.Jan 26 2023, 8:51 AM
This revision was landed with ongoing or failed builds.Jan 26 2023, 8:53 AM
This revision was automatically updated to reflect the committed changes.