This is an archive of the discontinued LLVM Phabricator instance.

Differential D142400

[cmake] Remove RISCVTargetParserTableGen from LLVMConfig.cmake.in
AbandonedPublic

Authored by fpetrogalli on Jan 23 2023, 1:20 PM.

Details

Reviewers
tstellar
mgorny
jdoerfert
Summary

As discussed in https://reviews.llvm.org/D141581, it seems that the
target RISCVTargetParserTableGen does not need the same treatment as
other tablegen-generated headers.

Diff Detail

Event Timeline

fpetrogalli created this revision.Jan 23 2023, 1:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 23 2023, 1:20 PM
Herald added subscribers: VincentWu, vkmr, evandro and 12 others. · View Herald Transcript
fpetrogalli requested review of this revision.Jan 23 2023, 1:20 PM
Herald added a reviewer: jdoerfert. · View Herald TranscriptJan 23 2023, 1:20 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, • pcwang-thead, eopXD, sstefan1. · View Herald Transcript
fpetrogalli abandoned this revision.Jan 23 2023, 1:48 PM

This was essentially reverted in https://reviews.llvm.org/rG20ffb9aaf982, so I am abandoning it in favour of https://reviews.llvm.org/D142403

Harbormaster completed remote builds in B209461: Diff 491493.Jan 23 2023, 3:10 PM

Revision Contents

PathSize
llvm/
cmake/
modules/
9 lines

Diff 491493

llvm/cmake/modules/LLVMConfig.cmake.in

Show First 20 Lines • Show All 134 Lines • ▼ Show 20 Lines
set(LLVM_HAVE_LIBXAR "@LLVM_HAVE_LIBXAR@") set(LLVM_HAVE_LIBXAR "@LLVM_HAVE_LIBXAR@")
if(NOT TARGET LLVMSupport) if(NOT TARGET LLVMSupport)
@LLVM_CONFIG_INCLUDE_EXPORTS@ @LLVM_CONFIG_INCLUDE_EXPORTS@
@llvm_config_include_buildtree_only_exports@ @llvm_config_include_buildtree_only_exports@
endif() endif()
# By creating the following targets here, subprojects that depend on # By creating intrinsics_gen, omp_gen and acc_gen here, subprojects that depend
# LLVM's tablegen-generated headers can always depend on this target # on LLVM's tablegen-generated headers can always depend on this target whether
# whether building in-tree with LLVM or not. # building in-tree with LLVM or not.
if(NOT TARGET intrinsics_gen) if(NOT TARGET intrinsics_gen)
add_custom_target(intrinsics_gen) add_custom_target(intrinsics_gen)
endif() endif()
if(NOT TARGET omp_gen) if(NOT TARGET omp_gen)
add_custom_target(omp_gen) add_custom_target(omp_gen)
endif() endif()
if(NOT TARGET acc_gen) if(NOT TARGET acc_gen)
add_custom_target(acc_gen) add_custom_target(acc_gen)
endif() endif()
if(NOT TARGET RISCVTargetParserTableGen)
add_custom_target(RISCVTargetParserTableGen)
endif()
set_property(GLOBAL PROPERTY LLVM_TARGETS_CONFIGURED On) set_property(GLOBAL PROPERTY LLVM_TARGETS_CONFIGURED On)
include(${LLVM_CMAKE_DIR}/LLVM-Config.cmake) include(${LLVM_CMAKE_DIR}/LLVM-Config.cmake)