This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy][NFC] Use C++17 nested namespaces in clang-tidy headers
ClosedPublic

Authored by carlosgalvezp on Jan 22 2023, 8:32 AM.

Details

Summary

We forgot to apply the change to headers in the previous patch,
due to missing "-header-filter" in the run-clang-tidy invocation.

Diff Detail

Event Timeline

carlosgalvezp created this revision.Jan 22 2023, 8:32 AM
Herald added a reviewer: njames93. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
carlosgalvezp requested review of this revision.Jan 22 2023, 8:32 AM
Eugene.Zelenko accepted this revision.Jan 22 2023, 9:34 AM

Looks OK for me, but please fix small formatting issues. Will be good idea to await for other eyes.

clang-tools-extra/clang-tidy/utils/FixItHintUtils.h
47

Please separate with newline.

clang-tools-extra/clang-tidy/utils/IncludeInserter.h
19–20

Ditto.

clang-tools-extra/clang-tidy/utils/IncludeSorter.h
75

Ditto,

This revision is now accepted and ready to land.Jan 22 2023, 9:34 AM

Looks OK for me, but please fix small formatting issues. Will be good idea to await for other eyes.

Thanks for the quick review! I applied clang-format to the patch; any additional manual formatting wanted belongs in a separate patch IMHO.