Page MenuHomePhabricator
Differential D141682

[MLIR][LLVM] Support inlining LLVM::CallOp to LLVM::FuncOp.
ClosedPublic
Actions

Authored by definelicht on Jan 13 2023, 5:43 AM.

Details

Reviewers
ftynse
nicolasvasilache
dcaballe
gysit
Dinistro
mehdi_amini
Commits
rGeef538f4e11c: [MLIR][LLVM] Support inlining LLVM::CallOp to LLVM::FuncOp.
Summary

Extend LLVMInlinerInterface to handle calls from an LLVM::CallOp to
an LLVM::FuncOp when there are no attributes present that require
special handling.

Depends on D141676

Diff Detail

Event Timeline

definelicht created this revision.Jan 13 2023, 5:43 AM
Herald added a reviewer: ftynse. · View Herald TranscriptJan 13 2023, 5:43 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: Moerafaat, zero9178, bzcheeseman and 21 others. · View Herald Transcript
definelicht requested review of this revision.Jan 13 2023, 5:43 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptJan 13 2023, 5:43 AM
Herald added a reviewer: dcaballe. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B207616: Diff 488971.Jan 13 2023, 6:30 AM
definelicht updated this revision to Diff 490185.Jan 18 2023, 8:35 AM

Rebase on the commit that this is stacked on.

Harbormaster completed remote builds in B208514: Diff 490185.Jan 18 2023, 9:53 AM
definelicht added reviewers: gysit, Dinistro.Jan 19 2023, 12:03 AM
gysit accepted this revision.Jan 19 2023, 12:50 AM

LGTM!

This revision is now accepted and ready to land.Jan 19 2023, 12:50 AM
definelicht updated this revision to Diff 490441.Jan 19 2023, 3:20 AM

Rebase on commit that treats llvm.return.

definelicht added a reviewer: mehdi_amini.Jan 19 2023, 3:21 AM
Harbormaster completed remote builds in B208705: Diff 490441.Jan 19 2023, 3:40 AM
definelicht updated this revision to Diff 490501.Jan 19 2023, 6:52 AM

Allow inlining functions with the newly added memory attribute.

This revision was landed with ongoing or failed builds.Jan 20 2023, 7:27 AM
Closed by commit rGeef538f4e11c: [MLIR][LLVM] Support inlining LLVM::CallOp to LLVM::FuncOp. (authored by definelicht, committed by Dinistro). · Explain Why
This revision was automatically updated to reflect the committed changes.
Dinistro added a commit: rGeef538f4e11c: [MLIR][LLVM] Support inlining LLVM::CallOp to LLVM::FuncOp..
definelicht added a child revision: D142436: [MLIR][LLVM] Support inlining of LLVM::AllocaOp..Jan 24 2023, 12:42 AM

Revision Contents
Changeset List

PathSize
mlir/
lib/
Dialect/
LLVMIR/
IR/
94 lines
test/
Dialect/
LLVMIR/
137 lines

Diff 490846

View Options

mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp

Loading...
View Options

mlir/test/Dialect/LLVMIR/inlining.mlir

Loading...