Page MenuHomePhabricator

definelicht (Johannes de Fine Licht)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 24 2022, 1:07 AM (15 w, 2 d)

Recent Activity

Fri, Jan 27

definelicht updated the diff for D142701: [MLIR][LLVM] Generate LLVM lifetime intrinsics while inlining..

Drop MLIRAnalysis dependency in favor of simple stack-based implementation.

Fri, Jan 27, 12:49 PM · Restricted Project, Restricted Project
definelicht added reviewers for D142701: [MLIR][LLVM] Generate LLVM lifetime intrinsics while inlining.: gysit, Dinistro.
Fri, Jan 27, 3:30 AM · Restricted Project, Restricted Project
definelicht requested review of D142701: [MLIR][LLVM] Generate LLVM lifetime intrinsics while inlining..
Fri, Jan 27, 3:29 AM · Restricted Project, Restricted Project

Thu, Jan 26

definelicht updated the diff for D142436: [MLIR][LLVM] Support inlining of LLVM::AllocaOp..

Address ultra nit on capitalization.

Thu, Jan 26, 4:46 AM · Restricted Project, Restricted Project
definelicht updated the diff for D142436: [MLIR][LLVM] Support inlining of LLVM::AllocaOp..

Update inline comment.

Thu, Jan 26, 4:21 AM · Restricted Project, Restricted Project

Wed, Jan 25

definelicht updated the diff for D142436: [MLIR][LLVM] Support inlining of LLVM::AllocaOp..

Update signature and tests.

Wed, Jan 25, 1:25 AM · Restricted Project, Restricted Project

Tue, Jan 24

definelicht updated the diff for D142436: [MLIR][LLVM] Support inlining of LLVM::AllocaOp..

Purged outdated comment.

Tue, Jan 24, 12:44 AM · Restricted Project, Restricted Project
definelicht requested review of D142436: [MLIR][LLVM] Support inlining of LLVM::AllocaOp..
Tue, Jan 24, 12:42 AM · Restricted Project, Restricted Project
definelicht added inline comments to D142372: [mlir][LLVM] Add param attr verifiers.
Tue, Jan 24, 12:26 AM · Restricted Project, Restricted Project

Thu, Jan 19

definelicht updated the diff for D141682: [MLIR][LLVM] Support inlining LLVM::CallOp to LLVM::FuncOp..

Allow inlining functions with the newly added memory attribute.

Thu, Jan 19, 6:52 AM · Restricted Project, Restricted Project
definelicht added a reviewer for D141682: [MLIR][LLVM] Support inlining LLVM::CallOp to LLVM::FuncOp.: mehdi_amini.
Thu, Jan 19, 3:21 AM · Restricted Project, Restricted Project
definelicht updated the diff for D141682: [MLIR][LLVM] Support inlining LLVM::CallOp to LLVM::FuncOp..

Rebase on commit that treats llvm.return.

Thu, Jan 19, 3:20 AM · Restricted Project, Restricted Project
definelicht added a comment to D142086: [mlir][llvm] Drop cyclic dependencies during debug metadata import..

I think the title of the commit should reflect the band aid nature of it 🙂

Thu, Jan 19, 12:52 AM · Restricted Project, Restricted Project
definelicht added reviewers for D141682: [MLIR][LLVM] Support inlining LLVM::CallOp to LLVM::FuncOp.: gysit, Dinistro.
Thu, Jan 19, 12:03 AM · Restricted Project, Restricted Project

Wed, Jan 18

definelicht updated the diff for D141682: [MLIR][LLVM] Support inlining LLVM::CallOp to LLVM::FuncOp..

Rebase on the commit that this is stacked on.

Wed, Jan 18, 8:35 AM · Restricted Project, Restricted Project
definelicht updated the diff for D141676: [MLIR][LLVM] Don't use void return type in `getCallableResults`..

Restrict change to getCallableResults. Don't touch parsing.

Wed, Jan 18, 8:33 AM · Restricted Project, Restricted Project
definelicht added a comment to D141676: [MLIR][LLVM] Don't use void return type in `getCallableResults`..

I made an attempt at burninating LLVMVoidType and using an unconstructed/null Type, but this quickly seemed like a bad idea: It's still relying on a sentinel type, but a much less explicit one, and it breaks the assumption that we can access APIs on Types all over the code. This seems like an overall reduction in code readability.

Wed, Jan 18, 8:27 AM · Restricted Project, Restricted Project
definelicht added a comment to D141676: [MLIR][LLVM] Don't use void return type in `getCallableResults`..

Alternatively, we can eliminate LLVMVoidType completely from the type system and use the empty list of results in the function type instead.

Wed, Jan 18, 5:22 AM · Restricted Project, Restricted Project

Fri, Jan 13

definelicht added a comment to D141676: [MLIR][LLVM] Don't use void return type in `getCallableResults`..

I'm not convinced by this change. It creates unclear special casing, e.g., calling the getResults() on the LLVMFunctionOp will return different results than calling getFunctionType().getResults(). The parser is not expected to see !llvm.void, but the type builder is. There is no mechanism left to check the presence of the void result type textually.

Have you considered (a) removing the void type entirely, (b) relaxing whatever caller/callee constraints to accommodate this?

Fri, Jan 13, 7:25 AM · Restricted Project, Restricted Project
definelicht requested review of D141682: [MLIR][LLVM] Support inlining LLVM::CallOp to LLVM::FuncOp..
Fri, Jan 13, 5:43 AM · Restricted Project, Restricted Project
definelicht requested review of D141676: [MLIR][LLVM] Don't use void return type in `getCallableResults`..
Fri, Jan 13, 4:21 AM · Restricted Project, Restricted Project

Tue, Jan 10

definelicht accepted D141357: [mlir][llvm] Improve error messages during LLVM IR import..

LGTM!

Tue, Jan 10, 1:04 AM · Restricted Project, Restricted Project

Jan 9 2023

definelicht added inline comments to D141261: [mlir][llvm] Add an explicit void type debug info attribute..
Jan 9 2023, 1:20 AM · Restricted Project, Restricted Project, Restricted Project

Jan 6 2023

definelicht updated the diff for D141115: [mlir:LLVM] Rudimentary inlining support for LLVM load store..

Move inlined functions above the function they are being inlined into.

Jan 6 2023, 7:37 AM · Restricted Project, Restricted Project
definelicht added a reviewer for D141115: [mlir:LLVM] Rudimentary inlining support for LLVM load store.: ingomueller-net.
Jan 6 2023, 2:01 AM · Restricted Project, Restricted Project
definelicht added reviewers for D141115: [mlir:LLVM] Rudimentary inlining support for LLVM load store.: Dinistro, gysit.
Jan 6 2023, 2:01 AM · Restricted Project, Restricted Project
definelicht requested review of D141115: [mlir:LLVM] Rudimentary inlining support for LLVM load store..
Jan 6 2023, 1:21 AM · Restricted Project, Restricted Project

Oct 25 2022

definelicht requested review of D136669: [mlir][llvm] Don't return a dangling reference in getCallableResults()..
Oct 25 2022, 2:10 AM · Restricted Project, Restricted Project