This is an archive of the discontinued LLVM Phabricator instance.

[AArch64][SME]: Make 'Expand' the default action for all Ops.
ClosedPublic

Authored by hassnaa-arm on Jan 5 2023, 9:11 AM.

Details

Summary

By default expand all operations, then change to Custom/Legal if needed.
[AArch64][SME]: By default, Expand all the operations.

Diff Detail

Event Timeline

hassnaa-arm created this revision.Jan 5 2023, 9:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 5 2023, 9:11 AM
hassnaa-arm requested review of this revision.Jan 5 2023, 9:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 5 2023, 9:11 AM
sdesmalen added inline comments.Jan 6 2023, 3:51 AM
llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
1442

Please move this loop where it marks all the operations as Expand into addTypeForStreamingSVE.

1664–1666

Can you add a comment for these operations that we mark them as Legal because we can use streaming-compatible NEON instructions for these?

4329

Can you split out this change, along with marking BITCAST as custom, into a separate patch?

hassnaa-arm added inline comments.Jan 6 2023, 4:07 AM
llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
4329

Removing BITCAST from this patch will cause a crash to some testing files, is that okay ?

sdesmalen added inline comments.Jan 6 2023, 4:09 AM
llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
4329

That is not okay :) It just means you need to reorder the patch so the other one comes first.

Mark BITCAST as Legal, no need to Custom-lower it.

hassnaa-arm marked 2 inline comments as done.Jan 6 2023, 5:08 AM
hassnaa-arm added inline comments.Jan 6 2023, 5:16 AM
llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
4329

I found that I was mistaken about custom-lowering BITCAST. No need for making it custom.

sdesmalen accepted this revision.Jan 6 2023, 5:22 AM
sdesmalen added inline comments.
llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
1668

Please add newline above.

1674

Please add newline above.

This revision is now accepted and ready to land.Jan 6 2023, 5:22 AM
hassnaa-arm marked 2 inline comments as done.Jan 6 2023, 6:38 AM

Add new empty lines

This revision was landed with ongoing or failed builds.Jan 6 2023, 7:32 AM
This revision was automatically updated to reflect the committed changes.