This matches OpenBSD and FreeBSD.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Time | Test | |
---|---|---|
4,210 ms | x64 debian > Clang.Driver::netbsd.cpp Script:
--
: 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang --driver-mode=g++ --target=x86_64-unknown-netbsd -stdlib=platform --sysroot=/var/lib/buildkite-agent/builds/llvm-project/clang/test/Driver/Inputs/basic_netbsd_tree -### /var/lib/buildkite-agent/builds/llvm-project/clang/test/Driver/netbsd.cpp 2>&1 | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck -check-prefix=X86_64 /var/lib/buildkite-agent/builds/llvm-project/clang/test/Driver/netbsd.cpp
|
Event Timeline
Comment Actions
Hi @brad ,
would you fix the tests
https://lab.llvm.org/buildbot/#/builders/60/builds/10125
looks like the problem is here:
// DRIVER-PASS-INCLUDES: "-internal-externc-isystem" "/usr/include"
could be another path instead of "/usr/include".
this one should work for the most cases
// DRIVER-PASS-INCLUDES: "-internal-externc-isystem" "{{.*}}/usr/include"
Comment Actions
Hi @brad,
thank you for fixing the broken tests.
There is still a problem with netbsd.c test: https://lab.llvm.org/buildbot/#/builders/60/builds/10135/steps/9/logs/FAIL__Clang__netbsd_c
Here:
// DRIVER-PASS-INCLUDES-SAME: {{^}} "-internal-isystem" "[[RESOURCE]]{{/|\\\\}}include" // DRIVER-PASS-INCLUDES-SAME: {{^}} "-internal-externc-isystem" "{{.*}}/usr/include"
The first's {{^}} breaks the test. It can be removed from the first line or from the both of them.
The tests are getting passed without this part on the win-x-cross builders. They should work on Linux/BSD hosts with these changes.
Would you check and update the tests accordingly?
The following changes are working on my cross builders
// DRIVER-PASS-INCLUDES-SAME: "-internal-isystem" "[[RESOURCE]]{{/|\\\\}}include" // DRIVER-PASS-INCLUDES-SAME: {{^}} "-internal-externc-isystem" "{{.*}}/usr/include"
and
// DRIVER-PASS-INCLUDES-SAME: "-internal-isystem" "[[RESOURCE]]{{/|\\\\}}include" // DRIVER-PASS-INCLUDES-SAME: "-internal-externc-isystem" "{{.*}}/usr/include"