This is an archive of the discontinued LLVM Phabricator instance.

Differential D140403

[RISCV] Add more XVentanaCondOps tests with icmp conditions. NFC
ClosedPublic

Authored by craig.topper on Dec 20 2022, 7:54 AM.

Details

Reviewers
reames
asb
luismarques
kconsul
Commits
rG7f9dc7bf8535: [RISCV] Add more XVentanaCondOps tests with icmp conditions. NFC
Summary

Most of our existing tests use i1 arguments for the conditions.
With icmp conditions there are opportunities for improving the
generated code.

Diff Detail

Unit TestsFailed

TimeTest
60,030 msx64 debian > libFuzzer.libFuzzer::minimize_crash.test

Event Timeline

craig.topper created this revision.Dec 20 2022, 7:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 20 2022, 7:54 AM
Herald added subscribers: sunshaoce, VincentWu, StephenFan and 26 others. · View Herald Transcript
craig.topper requested review of this revision.Dec 20 2022, 7:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 20 2022, 7:54 AM
Herald added subscribers: • pcwang-thead, eopXD, MaskRay. · View Herald Transcript
Harbormaster completed remote builds in B204165: Diff 484276.Dec 20 2022, 9:13 AM
craig.topper updated this revision to Diff 484316.Dec 20 2022, 10:30 AM

Add tests with seteq/setne with a constant RHS.

reames accepted this revision.Dec 20 2022, 11:01 AM

LGTM

This revision is now accepted and ready to land.Dec 20 2022, 11:01 AM
This revision was landed with ongoing or failed builds.Dec 20 2022, 11:36 AM
Closed by commit rG7f9dc7bf8535: [RISCV] Add more XVentanaCondOps tests with icmp conditions. NFC (authored by craig.topper). · Explain Why
This revision was automatically updated to reflect the committed changes.
craig.topper added a commit: rG7f9dc7bf8535: [RISCV] Add more XVentanaCondOps tests with icmp conditions. NFC.
Harbormaster completed remote builds in B204196: Diff 484316.Dec 20 2022, 11:51 AM

Revision Contents

PathSize
llvm/
test/
CodeGen/
RISCV/
278 lines

Diff 484276

llvm/test/CodeGen/RISCV/xventanacondops.ll

Show First 20 Lines • Show All 225 Lines • ▼ Show 20 Lines
; CHECK: # %bb.0: ; CHECK: # %bb.0:
; CHECK-NEXT: vt.maskcn a2, a2, a0 ; CHECK-NEXT: vt.maskcn a2, a2, a0
; CHECK-NEXT: vt.maskc a0, a1, a0 ; CHECK-NEXT: vt.maskc a0, a1, a0
; CHECK-NEXT: or a0, a0, a2 ; CHECK-NEXT: or a0, a0, a2
; CHECK-NEXT: ret ; CHECK-NEXT: ret
%sel = select i1 %rc, i64 %rs1, i64 %rs2 %sel = select i1 %rc, i64 %rs1, i64 %rs2
ret i64 %sel ret i64 %sel
} }
define i64 @seteq(i64 %a, i64 %b, i64 %rs1, i64 %rs2) {
; CHECK-LABEL: seteq:
; CHECK: # %bb.0:
; CHECK-NEXT: xor a0, a0, a1
; CHECK-NEXT: seqz a0, a0
; CHECK-NEXT: vt.maskcn a1, a3, a0
; CHECK-NEXT: vt.maskc a0, a2, a0
; CHECK-NEXT: or a0, a0, a1
; CHECK-NEXT: ret
%rc = icmp eq i64 %a, %b
%sel = select i1 %rc, i64 %rs1, i64 %rs2
ret i64 %sel
}
define i64 @setne(i64 %a, i64 %b, i64 %rs1, i64 %rs2) {
; CHECK-LABEL: setne:
; CHECK: # %bb.0:
; CHECK-NEXT: xor a0, a0, a1
; CHECK-NEXT: snez a0, a0
; CHECK-NEXT: vt.maskcn a1, a3, a0
; CHECK-NEXT: vt.maskc a0, a2, a0
; CHECK-NEXT: or a0, a0, a1
; CHECK-NEXT: ret
%rc = icmp ne i64 %a, %b
%sel = select i1 %rc, i64 %rs1, i64 %rs2
ret i64 %sel
}
define i64 @setgt(i64 %a, i64 %b, i64 %rs1, i64 %rs2) {
; CHECK-LABEL: setgt:
; CHECK: # %bb.0:
; CHECK-NEXT: slt a0, a1, a0
; CHECK-NEXT: vt.maskcn a1, a3, a0
; CHECK-NEXT: vt.maskc a0, a2, a0
; CHECK-NEXT: or a0, a0, a1
; CHECK-NEXT: ret
%rc = icmp sgt i64 %a, %b
%sel = select i1 %rc, i64 %rs1, i64 %rs2
ret i64 %sel
}
define i64 @setge(i64 %a, i64 %b, i64 %rs1, i64 %rs2) {
; CHECK-LABEL: setge:
; CHECK: # %bb.0:
; CHECK-NEXT: slt a0, a0, a1
; CHECK-NEXT: vt.maskcn a1, a2, a0
; CHECK-NEXT: vt.maskc a0, a3, a0
; CHECK-NEXT: or a0, a0, a1
; CHECK-NEXT: ret
%rc = icmp sge i64 %a, %b
%sel = select i1 %rc, i64 %rs1, i64 %rs2
ret i64 %sel
}
define i64 @setlt(i64 %a, i64 %b, i64 %rs1, i64 %rs2) {
; CHECK-LABEL: setlt:
; CHECK: # %bb.0:
; CHECK-NEXT: slt a0, a0, a1
; CHECK-NEXT: vt.maskcn a1, a3, a0
; CHECK-NEXT: vt.maskc a0, a2, a0
; CHECK-NEXT: or a0, a0, a1
; CHECK-NEXT: ret
%rc = icmp slt i64 %a, %b
%sel = select i1 %rc, i64 %rs1, i64 %rs2
ret i64 %sel
}
define i64 @setle(i64 %a, i64 %b, i64 %rs1, i64 %rs2) {
; CHECK-LABEL: setle:
; CHECK: # %bb.0:
; CHECK-NEXT: slt a0, a1, a0
; CHECK-NEXT: vt.maskcn a1, a2, a0
; CHECK-NEXT: vt.maskc a0, a3, a0
; CHECK-NEXT: or a0, a0, a1
; CHECK-NEXT: ret
%rc = icmp sle i64 %a, %b
%sel = select i1 %rc, i64 %rs1, i64 %rs2
ret i64 %sel
}
define i64 @setugt(i64 %a, i64 %b, i64 %rs1, i64 %rs2) {
; CHECK-LABEL: setugt:
; CHECK: # %bb.0:
; CHECK-NEXT: sltu a0, a1, a0
; CHECK-NEXT: vt.maskcn a1, a3, a0
; CHECK-NEXT: vt.maskc a0, a2, a0
; CHECK-NEXT: or a0, a0, a1
; CHECK-NEXT: ret
%rc = icmp ugt i64 %a, %b
%sel = select i1 %rc, i64 %rs1, i64 %rs2
ret i64 %sel
}
define i64 @setuge(i64 %a, i64 %b, i64 %rs1, i64 %rs2) {
; CHECK-LABEL: setuge:
; CHECK: # %bb.0:
; CHECK-NEXT: sltu a0, a0, a1
; CHECK-NEXT: vt.maskcn a1, a2, a0
; CHECK-NEXT: vt.maskc a0, a3, a0
; CHECK-NEXT: or a0, a0, a1
; CHECK-NEXT: ret
%rc = icmp uge i64 %a, %b
%sel = select i1 %rc, i64 %rs1, i64 %rs2
ret i64 %sel
}
define i64 @setult(i64 %a, i64 %b, i64 %rs1, i64 %rs2) {
; CHECK-LABEL: setult:
; CHECK: # %bb.0:
; CHECK-NEXT: sltu a0, a0, a1
; CHECK-NEXT: vt.maskcn a1, a3, a0
; CHECK-NEXT: vt.maskc a0, a2, a0
; CHECK-NEXT: or a0, a0, a1
; CHECK-NEXT: ret
%rc = icmp ult i64 %a, %b
%sel = select i1 %rc, i64 %rs1, i64 %rs2
ret i64 %sel
}
define i64 @setule(i64 %a, i64 %b, i64 %rs1, i64 %rs2) {
; CHECK-LABEL: setule:
; CHECK: # %bb.0:
; CHECK-NEXT: sltu a0, a1, a0
; CHECK-NEXT: vt.maskcn a1, a2, a0
; CHECK-NEXT: vt.maskc a0, a3, a0
; CHECK-NEXT: or a0, a0, a1
; CHECK-NEXT: ret
%rc = icmp ule i64 %a, %b
%sel = select i1 %rc, i64 %rs1, i64 %rs2
ret i64 %sel
}
define i64 @seteq_zero(i64 %a, i64 %rs1, i64 %rs2) {
; CHECK-LABEL: seteq_zero:
; CHECK: # %bb.0:
; CHECK-NEXT: seqz a0, a0
; CHECK-NEXT: vt.maskcn a2, a2, a0
; CHECK-NEXT: vt.maskc a0, a1, a0
; CHECK-NEXT: or a0, a0, a2
; CHECK-NEXT: ret
%rc = icmp eq i64 %a, 0
%sel = select i1 %rc, i64 %rs1, i64 %rs2
ret i64 %sel
}
define i64 @setne_zero(i64 %a, i64 %rs1, i64 %rs2) {
; CHECK-LABEL: setne_zero:
; CHECK: # %bb.0:
; CHECK-NEXT: snez a0, a0
; CHECK-NEXT: vt.maskcn a2, a2, a0
; CHECK-NEXT: vt.maskc a0, a1, a0
; CHECK-NEXT: or a0, a0, a2
; CHECK-NEXT: ret
%rc = icmp ne i64 %a, 0
%sel = select i1 %rc, i64 %rs1, i64 %rs2
ret i64 %sel
}
define i64 @seteq_constant(i64 %a, i64 %rs1, i64 %rs2) {
; CHECK-LABEL: seteq_constant:
; CHECK: # %bb.0:
; CHECK-NEXT: addi a0, a0, -123
; CHECK-NEXT: seqz a0, a0
; CHECK-NEXT: vt.maskcn a2, a2, a0
; CHECK-NEXT: vt.maskc a0, a1, a0
; CHECK-NEXT: or a0, a0, a2
; CHECK-NEXT: ret
%rc = icmp eq i64 %a, 123
%sel = select i1 %rc, i64 %rs1, i64 %rs2
ret i64 %sel
}
define i64 @setne_constant(i64 %a, i64 %rs1, i64 %rs2) {
; CHECK-LABEL: setne_constant:
; CHECK: # %bb.0:
; CHECK-NEXT: addi a0, a0, -456
; CHECK-NEXT: snez a0, a0
; CHECK-NEXT: vt.maskcn a2, a2, a0
; CHECK-NEXT: vt.maskc a0, a1, a0
; CHECK-NEXT: or a0, a0, a2
; CHECK-NEXT: ret
%rc = icmp ne i64 %a, 456
%sel = select i1 %rc, i64 %rs1, i64 %rs2
ret i64 %sel
}
define i64 @zero1_seteq(i64 %a, i64 %b, i64 %rs1) {
; CHECK-LABEL: zero1_seteq:
; CHECK: # %bb.0:
; CHECK-NEXT: xor a0, a0, a1
; CHECK-NEXT: seqz a0, a0
; CHECK-NEXT: vt.maskc a0, a2, a0
; CHECK-NEXT: ret
%rc = icmp eq i64 %a, %b
%sel = select i1 %rc, i64 %rs1, i64 0
ret i64 %sel
}
define i64 @zero2_seteq(i64 %a, i64 %b, i64 %rs1) {
; CHECK-LABEL: zero2_seteq:
; CHECK: # %bb.0:
; CHECK-NEXT: xor a0, a0, a1
; CHECK-NEXT: seqz a0, a0
; CHECK-NEXT: vt.maskcn a0, a2, a0
; CHECK-NEXT: ret
%rc = icmp eq i64 %a, %b
%sel = select i1 %rc, i64 0, i64 %rs1
ret i64 %sel
}
define i64 @zero1_setne(i64 %a, i64 %b, i64 %rs1) {
; CHECK-LABEL: zero1_setne:
; CHECK: # %bb.0:
; CHECK-NEXT: xor a0, a0, a1
; CHECK-NEXT: snez a0, a0
; CHECK-NEXT: vt.maskc a0, a2, a0
; CHECK-NEXT: ret
%rc = icmp ne i64 %a, %b
%sel = select i1 %rc, i64 %rs1, i64 0
ret i64 %sel
}
define i64 @zero2_setne(i64 %a, i64 %b, i64 %rs1) {
; CHECK-LABEL: zero2_setne:
; CHECK: # %bb.0:
; CHECK-NEXT: xor a0, a0, a1
; CHECK-NEXT: snez a0, a0
; CHECK-NEXT: vt.maskcn a0, a2, a0
; CHECK-NEXT: ret
%rc = icmp ne i64 %a, %b
%sel = select i1 %rc, i64 0, i64 %rs1
ret i64 %sel
}
define i64 @zero1_seteq_zero(i64 %a, i64 %rs1) {
; CHECK-LABEL: zero1_seteq_zero:
; CHECK: # %bb.0:
; CHECK-NEXT: seqz a0, a0
; CHECK-NEXT: vt.maskc a0, a1, a0
; CHECK-NEXT: ret
%rc = icmp eq i64 %a, 0
%sel = select i1 %rc, i64 %rs1, i64 0
ret i64 %sel
}
define i64 @zero2_seteq_zero(i64 %a, i64 %rs1) {
; CHECK-LABEL: zero2_seteq_zero:
; CHECK: # %bb.0:
; CHECK-NEXT: seqz a0, a0
; CHECK-NEXT: vt.maskcn a0, a1, a0
; CHECK-NEXT: ret
%rc = icmp eq i64 %a, 0
%sel = select i1 %rc, i64 0, i64 %rs1
ret i64 %sel
}
define i64 @zero1_setne_zero(i64 %a, i64 %rs1) {
; CHECK-LABEL: zero1_setne_zero:
; CHECK: # %bb.0:
; CHECK-NEXT: snez a0, a0
; CHECK-NEXT: vt.maskc a0, a1, a0
; CHECK-NEXT: ret
%rc = icmp ne i64 %a, 0
%sel = select i1 %rc, i64 %rs1, i64 0
ret i64 %sel
}
define i64 @zero2_setne_zero(i64 %a, i64 %rs1) {
; CHECK-LABEL: zero2_setne_zero:
; CHECK: # %bb.0:
; CHECK-NEXT: snez a0, a0
; CHECK-NEXT: vt.maskcn a0, a1, a0
; CHECK-NEXT: ret
%rc = icmp ne i64 %a, 0
%sel = select i1 %rc, i64 0, i64 %rs1
ret i64 %sel
}