Added support to vectorize pooling ops, piggybacking on vectorization for convolution.
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Can you split it into 3 patches? I think they can be
- Add pooling named ops changes.
- DownscaleSizeOneWindowed2DConvolution for pooling ops changes.
- Add vectorization support for pooling ops.
Also, are the changes about convolution indexing maps needed...?
Yes.
Also, are the changes about convolution indexing maps needed...?
Those got changed when I auto generated the yaml file from the python script. My guess is someone manually edited the yaml file at some point instead of using the python script. I can revert those changes in convolution ops if you want me to.
This differential can be replaced by the following 3 chained differentials (descendent first) as per @hanchung 's suggestion:
https://reviews.llvm.org/D140188
https://reviews.llvm.org/D140187
https://reviews.llvm.org/D140186
Not sure which of the two options for differentials is easier to review, so not retiring this differential yet.