Page MenuHomePhabricator
Differential D139203

[AMDGPU] Fix wide spills
ClosedPublic
Actions

Authored by piotr on Dec 2 2022, 7:46 AM.

Details

Reviewers
mbrkusanin
foad
dstuttard
arsenm
rampitec
matejam
Commits
rG1e3abd82b9ed: [AMDGPU] Fix wide spills
Summary

Update spill code to account for new vector types with
bit widths: 288, 320, 352, 384.

Related to D138205.

Diff Detail

Unit TestsFailed
View All

TimeTest
1,680 msx64 debian > LLVM.CodeGen/AMDGPU::pei-build-av-spill.mir
Script: -- : 'RUN: at line 2'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx908 -verify-machineinstrs -amdgpu-spill-vgpr-to-agpr=0 -run-pass=prologepilog -o - /var/lib/buildkite-agent/builds/llvm-project/llvm/test/CodeGen/AMDGPU/pei-build-av-spill.mir | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck -check-prefix=MUBUF /var/lib/buildkite-agent/builds/llvm-project/llvm/test/CodeGen/AMDGPU/pei-build-av-spill.mir
1,410 msx64 debian > LLVM.CodeGen/AMDGPU::spill288.mir
Script: -- : 'RUN: at line 2'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/llc -march=amdgcn -mcpu=tahiti -run-pass=regallocfast -o - /var/lib/buildkite-agent/builds/llvm-project/llvm/test/CodeGen/AMDGPU/spill288.mir | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck -check-prefix=SPILLED /var/lib/buildkite-agent/builds/llvm-project/llvm/test/CodeGen/AMDGPU/spill288.mir
1,390 msx64 debian > LLVM.CodeGen/AMDGPU::spill320.mir
Script: -- : 'RUN: at line 2'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/llc -march=amdgcn -mcpu=tahiti -run-pass=regallocfast -o - /var/lib/buildkite-agent/builds/llvm-project/llvm/test/CodeGen/AMDGPU/spill320.mir | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck -check-prefix=SPILLED /var/lib/buildkite-agent/builds/llvm-project/llvm/test/CodeGen/AMDGPU/spill320.mir
1,460 msx64 debian > LLVM.CodeGen/AMDGPU::spill352.mir
Script: -- : 'RUN: at line 2'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/llc -march=amdgcn -mcpu=tahiti -run-pass=regallocfast -o - /var/lib/buildkite-agent/builds/llvm-project/llvm/test/CodeGen/AMDGPU/spill352.mir | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck -check-prefix=SPILLED /var/lib/buildkite-agent/builds/llvm-project/llvm/test/CodeGen/AMDGPU/spill352.mir
1,440 msx64 debian > LLVM.CodeGen/AMDGPU::spill384.mir
Script: -- : 'RUN: at line 2'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/llc -march=amdgcn -mcpu=tahiti -run-pass=regallocfast -o - /var/lib/buildkite-agent/builds/llvm-project/llvm/test/CodeGen/AMDGPU/spill384.mir | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck -check-prefix=SPILLED /var/lib/buildkite-agent/builds/llvm-project/llvm/test/CodeGen/AMDGPU/spill384.mir

Event Timeline

piotr created this revision.Dec 2 2022, 7:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 2 2022, 7:46 AM
Herald added subscribers: kosarev, foad, kerbowa and 8 others. · View Herald Transcript
piotr requested review of this revision.Dec 2 2022, 7:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 2 2022, 7:47 AM
Herald added subscribers: llvm-commits, wdng. · View Herald Transcript
piotr added reviewers: mbrkusanin, foad, dstuttard, arsenm, rampitec.Dec 2 2022, 7:48 AM
piotr added a reviewer: matejam.Dec 2 2022, 8:04 AM
arsenm requested changes to this revision.Dec 2 2022, 8:05 AM

Should also test AGPR

llvm/test/CodeGen/AMDGPU/spill288.mir
3–4

Should test with gfx90a to cover the AGPRs

126

Can you also test AGPR

This revision now requires changes to proceed.Dec 2 2022, 8:05 AM
Harbormaster completed remote builds in B200774: Diff 479640.Dec 2 2022, 8:52 AM
piotr updated this revision to Diff 480083.Dec 5 2022, 6:09 AM

Thanks - the extra set of tests has uncovered another issue in code.

piotr marked 2 inline comments as done.Dec 5 2022, 6:10 AM
arsenm accepted this revision.Dec 5 2022, 6:17 AM
This revision is now accepted and ready to land.Dec 5 2022, 6:17 AM
Harbormaster completed remote builds in B201098: Diff 480083.Dec 5 2022, 9:06 AM
piotr updated this revision to Diff 480398.Dec 6 2022, 2:14 AM

Updating patch to address two more issues detected by running tests in debug mode:

  • wrong opcodes used in getVGPRSpillSaveOpcode in the original patch
  • tests using insufficient spill slot size in my patch
Harbormaster completed remote builds in B201328: Diff 480398.Dec 6 2022, 7:08 AM
arsenm accepted this revision.Dec 6 2022, 8:52 AM
This revision was landed with ongoing or failed builds.Dec 7 2022, 1:24 AM
Closed by commit rG1e3abd82b9ed: [AMDGPU] Fix wide spills (authored by piotr). · Explain Why
This revision was automatically updated to reflect the committed changes.
piotr added a commit: rG1e3abd82b9ed: [AMDGPU] Fix wide spills.

Revision Contents
Changeset List

PathSize
llvm/
lib/
Target/
AMDGPU/
16 lines
76 lines
test/
CodeGen/
AMDGPU/
1008 lines
512 lines
125 lines
127 lines
129 lines
131 lines

Diff 480083

View Options

llvm/lib/Target/AMDGPU/SIInstrInfo.cpp

Loading...
View Options

llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp

Loading...
View Options

llvm/test/CodeGen/AMDGPU/pei-build-av-spill.mir

Loading...
View Options

llvm/test/CodeGen/AMDGPU/spill-agpr.mir

Loading...
View Options

llvm/test/CodeGen/AMDGPU/spill288.mir

Loading...
View Options

llvm/test/CodeGen/AMDGPU/spill320.mir

Loading...
View Options

llvm/test/CodeGen/AMDGPU/spill352.mir

Loading...
View Options

llvm/test/CodeGen/AMDGPU/spill384.mir

Loading...