Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

matejam (Mateja Marjanovic)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 4 2019, 3:49 AM (203 w, 4 d)

Recent Activity

Jul 13 2023

matejam committed rGfa46feb31481: [AMDGPU] Use V_FMA_MIX* more often (authored by matejam).
[AMDGPU] Use V_FMA_MIX* more often
Jul 13 2023, 7:58 AM · Restricted Project, Restricted Project
matejam closed D153544: [AMDGPU] Use V_FMA_MIX* more often.
Jul 13 2023, 7:58 AM · Restricted Project, Restricted Project
matejam updated the diff for D153544: [AMDGPU] Use V_FMA_MIX* more often.

Rebase again.

Jul 13 2023, 7:50 AM · Restricted Project, Restricted Project
matejam closed D155171: [AMDGPU] Precommit for more usage of V_FMA/MAD_MIX*.
Jul 13 2023, 7:31 AM · Restricted Project, Restricted Project
matejam updated the diff for D153544: [AMDGPU] Use V_FMA_MIX* more often.

Rebase and merge precommit.

Jul 13 2023, 7:29 AM · Restricted Project, Restricted Project
matejam committed rGd3140f936387: Precommit for more usage of V_FMA/MAD_MIX* (authored by matejam).
Precommit for more usage of V_FMA/MAD_MIX*
Jul 13 2023, 7:27 AM · Restricted Project, Restricted Project
matejam updated the diff for D153544: [AMDGPU] Use V_FMA_MIX* more often.

Add test with fneg as src modifier.
Something weird happening with patch application, maybe the parent review https://reviews.llvm.org/D155171 should be merged first?

Jul 13 2023, 7:23 AM · Restricted Project, Restricted Project
matejam updated the diff for D153544: [AMDGPU] Use V_FMA_MIX* more often.

Rebase.

Jul 13 2023, 7:12 AM · Restricted Project, Restricted Project
matejam updated the diff for D153544: [AMDGPU] Use V_FMA_MIX* more often.

Removed unnecessary flags from fmul instruction in tests.
Add test with abs as a src0 modifier.

Jul 13 2023, 7:07 AM · Restricted Project, Restricted Project
matejam committed rG701c4adceae5: Check for denormal flushing when selecting V_FMA/MAD_MIX* (authored by matejam).
Check for denormal flushing when selecting V_FMA/MAD_MIX*
Jul 13 2023, 6:29 AM · Restricted Project, Restricted Project
matejam updated the diff for D153544: [AMDGPU] Use V_FMA_MIX* more often.

Rebase.

Jul 13 2023, 5:53 AM · Restricted Project, Restricted Project
matejam added inline comments to D154824: [AMDGPU] Check for denormal flushing when selecting V_FMA/MAD_MIX*.
Jul 13 2023, 5:50 AM · Restricted Project, Restricted Project
matejam updated the diff for D153544: [AMDGPU] Use V_FMA_MIX* more often.

Use selection patterns for selecting V_FMA/MAD_MIX* instead of combiners.
With combiners there is a possibility that fptrunc (fmul a, b) would be selected into fptrunc (fma a, b, 0), and some other combiner could transform it back to its original state.

Jul 13 2023, 3:45 AM · Restricted Project, Restricted Project
matejam requested review of D155171: [AMDGPU] Precommit for more usage of V_FMA/MAD_MIX*.
Jul 13 2023, 3:41 AM · Restricted Project, Restricted Project
matejam updated the diff for D154824: [AMDGPU] Check for denormal flushing when selecting V_FMA/MAD_MIX*.

Added tests without denormal flushing as a function attribute.
In all cases except GFX900 it should have the same result as with denormal flushing.

Jul 13 2023, 3:03 AM · Restricted Project, Restricted Project
matejam updated the diff for D154824: [AMDGPU] Check for denormal flushing when selecting V_FMA/MAD_MIX*.

Since it doesn't affect any tests, should I add this line in D153544?

Jul 13 2023, 2:07 AM · Restricted Project, Restricted Project

Jul 10 2023

matejam added inline comments to D154824: [AMDGPU] Check for denormal flushing when selecting V_FMA/MAD_MIX*.
Jul 10 2023, 2:45 AM · Restricted Project, Restricted Project
matejam added a comment to D154824: [AMDGPU] Check for denormal flushing when selecting V_FMA/MAD_MIX*.

I could add a function attribute containing denormal flushing or add more run lines to these tests.

Jul 10 2023, 2:39 AM · Restricted Project, Restricted Project
matejam requested review of D154824: [AMDGPU] Check for denormal flushing when selecting V_FMA/MAD_MIX*.
Jul 10 2023, 2:38 AM · Restricted Project, Restricted Project

Jul 5 2023

matejam added a reviewer for D153544: [AMDGPU] Use V_FMA_MIX* more often: kosarev.
Jul 5 2023, 5:19 AM · Restricted Project, Restricted Project
matejam added a comment to D153544: [AMDGPU] Use V_FMA_MIX* more often.
Jul 5 2023, 4:26 AM · Restricted Project, Restricted Project
matejam added a reviewer for D153544: [AMDGPU] Use V_FMA_MIX* more often: mbrkusanin.
Jul 5 2023, 2:06 AM · Restricted Project, Restricted Project
matejam added inline comments to D153544: [AMDGPU] Use V_FMA_MIX* more often.
Jul 5 2023, 1:56 AM · Restricted Project, Restricted Project

Jul 4 2023

matejam added a comment to D153544: [AMDGPU] Use V_FMA_MIX* more often.

@foad do you think I should do something similar to Diff 2?
Or should I write AMDGPU-only combiners?
Or something else?

Jul 4 2023, 8:50 AM · Restricted Project, Restricted Project
matejam added inline comments to D153544: [AMDGPU] Use V_FMA_MIX* more often.
Jul 4 2023, 1:28 AM · Restricted Project, Restricted Project
matejam updated the diff for D153544: [AMDGPU] Use V_FMA_MIX* more often.

Remove add instruction from fptrunc + fmul -> v_fma/mad_mix*.

Jul 4 2023, 1:18 AM · Restricted Project, Restricted Project
matejam added a comment to D153544: [AMDGPU] Use V_FMA_MIX* more often.

Instead of writing patterns that select fma/mad_mix*, write combiners for sdag and global isel that will transform
fptrunc (fmul a, b) into fptrunc (fma a, b, 0), which will later be selected into v_fma/mad_mix*.

Jul 4 2023, 1:16 AM · Restricted Project, Restricted Project

Jul 3 2023

matejam updated the diff for D153544: [AMDGPU] Use V_FMA_MIX* more often.
Jul 3 2023, 4:01 PM · Restricted Project, Restricted Project

Jun 28 2023

matejam added inline comments to D153544: [AMDGPU] Use V_FMA_MIX* more often.
Jun 28 2023, 12:31 PM · Restricted Project, Restricted Project
matejam updated the diff for D153544: [AMDGPU] Use V_FMA_MIX* more often.

Transform fptrunc (mul a, b) -> fma_mix/mad_mix a, b, 0, implicit_def
or
build_vector el0, (fptrunc (mul a, b)) -> fma_mix/mad_mix a, b, 0, el0.

Jun 28 2023, 7:29 AM · Restricted Project, Restricted Project
matejam added a comment to D153544: [AMDGPU] Use V_FMA_MIX* more often.

@arsenm Would it be correct if I wrote a pattern in MadFmaMixPats multiclass, that finds (f16 (fptrunc (f32 (fmul %src1, %src2)))) and turns it into v_fma_mixlo_f16 %src1, %src2, 0.
The add would stay the same.

Jun 28 2023, 3:46 AM · Restricted Project, Restricted Project

Jun 22 2023

matejam added a reviewer for D153544: [AMDGPU] Use V_FMA_MIX* more often: dstuttard.
Jun 22 2023, 6:26 AM · Restricted Project, Restricted Project
matejam added a comment to D153544: [AMDGPU] Use V_FMA_MIX* more often.

Should it also be done for GlobalISel in the same patch?

Jun 22 2023, 6:24 AM · Restricted Project, Restricted Project
matejam added a comment to D153544: [AMDGPU] Use V_FMA_MIX* more often.

What other cases should I cover?
Should I cover the case when we have to pick the higher 16 bits of mul instruction and select v_fma_mixhi_f16?

Jun 22 2023, 6:21 AM · Restricted Project, Restricted Project
matejam requested review of D153544: [AMDGPU] Use V_FMA_MIX* more often.
Jun 22 2023, 6:19 AM · Restricted Project, Restricted Project

Jun 16 2023

matejam closed D147154: [AMDGPU][GlobalISel] Add codegen support for S_INDIRECT_REG_WRITE_MOVREL_B32_V[9|10|11|12].
Jun 16 2023, 2:06 AM · Restricted Project, Restricted Project
matejam closed D146737: [AMDGPU] Trim zero components from buffer and image stores.
Jun 16 2023, 2:01 AM · Restricted Project, Restricted Project

Jun 15 2023

matejam committed rG7047cb520373: [AMDGPU] Trim trailing undefs from the end of image and buffer store (authored by matejam).
[AMDGPU] Trim trailing undefs from the end of image and buffer store
Jun 15 2023, 6:20 AM · Restricted Project, Restricted Project
matejam closed D152440: [AMDGPU] Trim trailing undefs from the end of image and buffer store.
Jun 15 2023, 6:20 AM · Restricted Project, Restricted Project
matejam updated the diff for D152440: [AMDGPU] Trim trailing undefs from the end of image and buffer store.

Remove unnecessary if, use isNullValue instead of isZeroValue.
Thanks @foad.

Jun 15 2023, 6:01 AM · Restricted Project, Restricted Project
matejam updated the diff for D152440: [AMDGPU] Trim trailing undefs from the end of image and buffer store.

Rebase.

Jun 15 2023, 3:30 AM · Restricted Project, Restricted Project

Jun 9 2023

matejam updated the diff for D152440: [AMDGPU] Trim trailing undefs from the end of image and buffer store.

Instead of call to computeKnownFPClass, use findScalarElement.

Jun 9 2023, 4:55 AM · Restricted Project, Restricted Project

Jun 8 2023

matejam requested review of D152440: [AMDGPU] Trim trailing undefs from the end of image and buffer store.
Jun 8 2023, 6:02 AM · Restricted Project, Restricted Project

Jun 5 2023

matejam committed rGc91246b71eec: fix failures caused by https://reviews.llvm.org/D146737 (authored by matejam).
fix failures caused by https://reviews.llvm.org/D146737
Jun 5 2023, 4:13 AM · Restricted Project, Restricted Project
matejam committed rG88421ea97391: [AMDGPU] Trim zero components from buffer and image stores (authored by matejam).
[AMDGPU] Trim zero components from buffer and image stores
Jun 5 2023, 3:31 AM · Restricted Project, Restricted Project

Jun 2 2023

matejam requested review of D146737: [AMDGPU] Trim zero components from buffer and image stores.
Jun 2 2023, 7:14 AM · Restricted Project, Restricted Project
matejam updated the diff for D146737: [AMDGPU] Trim zero components from buffer and image stores.

Remove *_buffer_store instructions from being optimized.

Jun 2 2023, 6:54 AM · Restricted Project, Restricted Project

May 26 2023

matejam updated the diff for D146737: [AMDGPU] Trim zero components from buffer and image stores.

Add test case with all zero components.

May 26 2023, 10:16 AM · Restricted Project, Restricted Project
matejam reopened D146737: [AMDGPU] Trim zero components from buffer and image stores.

This patch was reverted on upstream, because of failed cts tests.

May 26 2023, 10:16 AM · Restricted Project, Restricted Project
matejam updated the diff for D146737: [AMDGPU] Trim zero components from buffer and image stores.

Change condition in for loop, instead of i >= 0, put i > 0. We don't want to optimize out the 0th element.

May 26 2023, 9:27 AM · Restricted Project, Restricted Project

May 22 2023

matejam added a comment to D146737: [AMDGPU] Trim zero components from buffer and image stores.

matejam added a reverting change: rG9c8c31eea439: Revert "[AMDGPU] Trim zero components from buffer and image stores".

Have you got any more details about what was wrong with it?

May 22 2023, 9:42 AM · Restricted Project, Restricted Project
matejam requested review of D151116: [AMDGPU][GlobalISel] Update legalization condition for G_BITCAST.
May 22 2023, 9:14 AM · Restricted Project, Restricted Project

May 18 2023

matejam added a reverting change for rG3181a6e3e7da: [AMDGPU] Trim zero components from buffer and image stores: rG9c8c31eea439: Revert "[AMDGPU] Trim zero components from buffer and image stores".
May 18 2023, 8:12 AM · Restricted Project, Restricted Project
matejam committed rG9c8c31eea439: Revert "[AMDGPU] Trim zero components from buffer and image stores" (authored by matejam).
Revert "[AMDGPU] Trim zero components from buffer and image stores"
May 18 2023, 8:12 AM · Restricted Project, Restricted Project
matejam added a reverting change for D146737: [AMDGPU] Trim zero components from buffer and image stores: rG9c8c31eea439: Revert "[AMDGPU] Trim zero components from buffer and image stores".
May 18 2023, 8:12 AM · Restricted Project, Restricted Project

May 15 2023

matejam committed rG3181a6e3e7da: [AMDGPU] Trim zero components from buffer and image stores (authored by matejam).
[AMDGPU] Trim zero components from buffer and image stores
May 15 2023, 9:24 AM · Restricted Project, Restricted Project
matejam closed D146737: [AMDGPU] Trim zero components from buffer and image stores.
May 15 2023, 9:24 AM · Restricted Project, Restricted Project
matejam updated the diff for D146737: [AMDGPU] Trim zero components from buffer and image stores.

Move the default case out of the switch.

May 15 2023, 7:41 AM · Restricted Project, Restricted Project
matejam updated the diff for D146737: [AMDGPU] Trim zero components from buffer and image stores.
May 15 2023, 7:38 AM · Restricted Project, Restricted Project
matejam updated the diff for D146737: [AMDGPU] Trim zero components from buffer and image stores.

Refactor.

May 15 2023, 7:31 AM · Restricted Project, Restricted Project
matejam updated the diff for D146737: [AMDGPU] Trim zero components from buffer and image stores.

Do the optimizations for image instructions that were done prior to this patch.

May 15 2023, 7:26 AM · Restricted Project, Restricted Project

May 10 2023

matejam updated the diff for D146737: [AMDGPU] Trim zero components from buffer and image stores.

Use Intrinsic opcode to know if the instructions has DMask instead of testing if the instruction has a ConstantInt as the second operand.
Add more run-lines to the test.

May 10 2023, 7:17 AM · Restricted Project, Restricted Project
matejam updated the diff for D146737: [AMDGPU] Trim zero components from buffer and image stores.

Change the name from findDemandedElts to trimTrailingZerosInVector.
Remove some unnecessary dyn_casts.
Refactor and rebase.

May 10 2023, 4:36 AM · Restricted Project, Restricted Project
matejam added a comment to D146737: [AMDGPU] Trim zero components from buffer and image stores.

Thanks for the review.

May 10 2023, 4:04 AM · Restricted Project, Restricted Project

May 8 2023

matejam added a comment to D146737: [AMDGPU] Trim zero components from buffer and image stores.

Please review this. @foad @arsenm

May 8 2023, 2:42 AM · Restricted Project, Restricted Project

May 3 2023

matejam added a reverting change for rG2e823da8dc65: Revert "[AMDGPU] Update LiveVariables in SILowerControlFlow": rGecf014e02b94: Revert "Revert "[AMDGPU] Update LiveVariables in SILowerControlFlow"".
May 3 2023, 8:38 AM · Restricted Project, Restricted Project
matejam committed rGecf014e02b94: Revert "Revert "[AMDGPU] Update LiveVariables in SILowerControlFlow"" (authored by matejam).
Revert "Revert "[AMDGPU] Update LiveVariables in SILowerControlFlow""
May 3 2023, 8:38 AM · Restricted Project, Restricted Project
matejam committed rGcf76074a366b: [AMDGPU][GlobalISel] Check exact width in get*ClassForBitWidth and widen if… (authored by matejam).
[AMDGPU][GlobalISel] Check exact width in get*ClassForBitWidth and widen if…
May 3 2023, 8:35 AM · Restricted Project, Restricted Project
matejam closed D148096: [AMDGPU][GlobalISel] Check exact width in get*ClassForBitWidth and widen if necessary.
May 3 2023, 8:35 AM · Restricted Project, Restricted Project
matejam added a reverting change for rGb25c7cafcbe1: [AMDGPU][GlobalISel] Widen the vector operand in G_BUILD/INSERT/EXTRACT_VECTOR: rG6175ec0bb694: Revert "[AMDGPU][GlobalISel] Widen the vector operand in….
May 3 2023, 8:29 AM · Restricted Project, Restricted Project
matejam committed rG6175ec0bb694: Revert "[AMDGPU][GlobalISel] Widen the vector operand in… (authored by matejam).
Revert "[AMDGPU][GlobalISel] Widen the vector operand in…
May 3 2023, 8:29 AM · Restricted Project, Restricted Project
matejam added a reverting change for rG069f027e1e6b: [AMDGPU] Update LiveVariables in SILowerControlFlow: rG2e823da8dc65: Revert "[AMDGPU] Update LiveVariables in SILowerControlFlow".
May 3 2023, 8:21 AM · Restricted Project, Restricted Project
matejam committed rG2e823da8dc65: Revert "[AMDGPU] Update LiveVariables in SILowerControlFlow" (authored by matejam).
Revert "[AMDGPU] Update LiveVariables in SILowerControlFlow"
May 3 2023, 8:21 AM · Restricted Project, Restricted Project
matejam committed rGb25c7cafcbe1: [AMDGPU][GlobalISel] Widen the vector operand in G_BUILD/INSERT/EXTRACT_VECTOR (authored by matejam).
[AMDGPU][GlobalISel] Widen the vector operand in G_BUILD/INSERT/EXTRACT_VECTOR
May 3 2023, 8:15 AM · Restricted Project, Restricted Project
matejam updated the diff for D146737: [AMDGPU] Trim zero components from buffer and image stores.

Rebase and change in comments.

May 3 2023, 7:19 AM · Restricted Project, Restricted Project
matejam retitled D148096: [AMDGPU][GlobalISel] Check exact width in get*ClassForBitWidth and widen if necessary from [AMDGPU][GlobalISel] Widen the vector operand in G_BUILD/INSERT/EXTRACT_VECTOR to [AMDGPU][GlobalISel] Check exact width in get*ClassForBitWidth and widen if necessary.
May 3 2023, 6:52 AM · Restricted Project, Restricted Project
matejam added a comment to D148096: [AMDGPU][GlobalISel] Check exact width in get*ClassForBitWidth and widen if necessary.

Needs new tests that now legalize? The test updates only show regressions?

May 3 2023, 6:04 AM · Restricted Project, Restricted Project

Apr 28 2023

matejam retitled D146737: [AMDGPU] Trim zero components from buffer and image stores from [AMDGPU] Default component broadcast store to [AMDGPU] Trim zero components from buffer and image stores.
Apr 28 2023, 9:53 AM · Restricted Project, Restricted Project
matejam updated the diff for D146737: [AMDGPU] Trim zero components from buffer and image stores.

Thank you @foad.
findDemandedElts with correct usage of computeKnownFPClass.

Apr 28 2023, 9:49 AM · Restricted Project, Restricted Project
matejam updated the diff for D146737: [AMDGPU] Trim zero components from buffer and image stores.

Changes in findDemandedElts, use computeKnownFPClass.

Apr 28 2023, 7:58 AM · Restricted Project, Restricted Project

Apr 27 2023

matejam added inline comments to D146737: [AMDGPU] Trim zero components from buffer and image stores.
Apr 27 2023, 8:13 AM · Restricted Project, Restricted Project
matejam updated the diff for D146737: [AMDGPU] Trim zero components from buffer and image stores.
Apr 27 2023, 8:07 AM · Restricted Project, Restricted Project
matejam added inline comments to D146737: [AMDGPU] Trim zero components from buffer and image stores.
Apr 27 2023, 6:59 AM · Restricted Project, Restricted Project

Apr 26 2023

matejam updated the diff for D146737: [AMDGPU] Trim zero components from buffer and image stores.

@foad @arsenm would you please review this?
Thank you.

Apr 26 2023, 2:31 AM · Restricted Project, Restricted Project
matejam added inline comments to D148096: [AMDGPU][GlobalISel] Check exact width in get*ClassForBitWidth and widen if necessary.
Apr 26 2023, 1:53 AM · Restricted Project, Restricted Project

Apr 25 2023

matejam updated the diff for D148096: [AMDGPU][GlobalISel] Check exact width in get*ClassForBitWidth and widen if necessary.
Apr 25 2023, 8:15 AM · Restricted Project, Restricted Project
matejam updated the diff for D148096: [AMDGPU][GlobalISel] Check exact width in get*ClassForBitWidth and widen if necessary.

Rebased.

Apr 25 2023, 5:12 AM · Restricted Project, Restricted Project
matejam updated the diff for D148096: [AMDGPU][GlobalISel] Check exact width in get*ClassForBitWidth and widen if necessary.

Moved call of moreElementsIf to the bottom. Made changes to customIf call for G_EXTRACT_VECTOR_ELT and G_INSERT_VECTOR_ELT.

Apr 25 2023, 4:40 AM · Restricted Project, Restricted Project

Apr 24 2023

matejam updated the diff for D148096: [AMDGPU][GlobalISel] Check exact width in get*ClassForBitWidth and widen if necessary.

Added named LegalityPredicate and LegalizeMutation for checking if the type doesn't have a corresponding AMDGPU RegClass and
if not, widenening the vector to the first next legal RegClass size.

Apr 24 2023, 9:06 AM · Restricted Project, Restricted Project
matejam added inline comments to D148096: [AMDGPU][GlobalISel] Check exact width in get*ClassForBitWidth and widen if necessary.
Apr 24 2023, 8:44 AM · Restricted Project, Restricted Project

Apr 20 2023

matejam updated the diff for D148096: [AMDGPU][GlobalISel] Check exact width in get*ClassForBitWidth and widen if necessary.
Apr 20 2023, 8:01 AM · Restricted Project, Restricted Project
matejam updated the diff for D148096: [AMDGPU][GlobalISel] Check exact width in get*ClassForBitWidth and widen if necessary.

This is an extension of https://reviews.llvm.org/D144198.
It includes checking the exact width in get*ClassForBitWidth and also widening of the vector operand of
G_BUILD_VECTOR, G_INSERT_VECTOR_ELT and G_EXTRACT_VECTOR_ELT instructions.

Apr 20 2023, 7:51 AM · Restricted Project, Restricted Project

Apr 12 2023

matejam updated the diff for D146737: [AMDGPU] Trim zero components from buffer and image stores.

Rebase and minor changes.

Apr 12 2023, 3:52 AM · Restricted Project, Restricted Project
matejam requested review of D148096: [AMDGPU][GlobalISel] Check exact width in get*ClassForBitWidth and widen if necessary.
Apr 12 2023, 2:44 AM · Restricted Project, Restricted Project

Apr 10 2023

matejam closed D147781: [AMDGPU] Extend tbuffer_load_format merge.

Closed, commit hash: f6e70ed1c73a2f3ac15eb6650423c1c10d278f50

Apr 10 2023, 6:06 AM · Restricted Project, Restricted Project
matejam committed rGf6e70ed1c73a: [AMDGPU] Extend tbuffer_load_format merge (authored by matejam).
[AMDGPU] Extend tbuffer_load_format merge
Apr 10 2023, 3:24 AM · Restricted Project, Restricted Project

Apr 7 2023

matejam requested review of D147781: [AMDGPU] Extend tbuffer_load_format merge.
Apr 7 2023, 4:35 AM · Restricted Project, Restricted Project

Apr 4 2023

matejam updated the diff for D146737: [AMDGPU] Trim zero components from buffer and image stores.

Use of SmallVector instead of VectorMap for tracking which components were already added.
Remove some unnecessary dyn_casts.

Apr 4 2023, 6:14 AM · Restricted Project, Restricted Project

Mar 30 2023

matejam committed rG48f6964bcbfb: [AMDGPU][GlobalISel] Add support for S_INDIRECT_REG_WRITE_MOVREL_B32_V… (authored by matejam).
[AMDGPU][GlobalISel] Add support for S_INDIRECT_REG_WRITE_MOVREL_B32_V…
Mar 30 2023, 9:28 AM · Restricted Project, Restricted Project
matejam added inline comments to D147154: [AMDGPU][GlobalISel] Add codegen support for S_INDIRECT_REG_WRITE_MOVREL_B32_V[9|10|11|12].
Mar 30 2023, 8:32 AM · Restricted Project, Restricted Project